Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: limit the number of users to 1 + number of system generated emails #25096

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

nsarupr
Copy link
Contributor

@nsarupr nsarupr commented Jul 5, 2023

Description

To check if the users repository is empty or not, we now limit the query to 1 more than the number of system generated emails. This will not work as expected, if we keep on adding new emails to system generated user emails.

PR fixes following issue(s)

Fixes [SCIM Bug]: Logging out of the Appsmith asks you to setup the instance again.

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing

How Has This Been Tested?

  • Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@nsarupr nsarupr requested a review from trishaanand July 5, 2023 05:39
@nsarupr nsarupr self-assigned this Jul 5, 2023
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo labels Jul 5, 2023
@nsarupr
Copy link
Contributor Author

nsarupr commented Jul 5, 2023

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5461106091.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25096.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25096&runId=5461106091_1

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5461106091.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@github-actions github-actions bot added the Bug Something isn't working label Jul 5, 2023
@nsarupr
Copy link
Contributor Author

nsarupr commented Jul 5, 2023

/ci-merge-check

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Merge check is running at: https://github.com/appsmithorg/appsmith/actions/runs/5461733946
PR: 25096

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Hurray!🎉 Proceeding to Merge!!!

@Aishwarya-U-R Aishwarya-U-R merged commit 512108b into release Jul 5, 2023
@Aishwarya-U-R Aishwarya-U-R deleted the chore/update-is-users-empty branch July 5, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SCIM Bug]: Logging out of the Appsmith asks you to setup the instance again.
3 participants