Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Split out the common component between SuperUser and NonSuperUser form #25061

Merged
merged 5 commits into from
Jul 5, 2023

Conversation

ankitsrivas14
Copy link
Contributor

@ankitsrivas14 ankitsrivas14 commented Jul 4, 2023

Split out the common component between SuperUser and NonSuperUser form

PR fixes following issue(s)

Fixes # #24120

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@ankitsrivas14 ankitsrivas14 self-assigned this Jul 4, 2023
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jul 4, 2023
@ankitsrivas14
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5453016962.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25061.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25061&runId=5453016962_1

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5453016962.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@dipyamanbiswas07
Copy link
Contributor

Please generate a DP and test it out.

Copy link
Contributor

@dipyamanbiswas07 dipyamanbiswas07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankitsrivas14
Copy link
Contributor Author

/build-deploy-preview recreate=true

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5455054146.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 25061.
recreate: true.

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Deploy-Preview-URL: https://ce-25061.dp.appsmith.com

@Aishwarya-U-R Aishwarya-U-R merged commit bc92b3d into release Jul 5, 2023
@Aishwarya-U-R Aishwarya-U-R deleted the chore/split-onboarding-components branch July 5, 2023 09:01
@Harshask93
Copy link

/build-deploy-preview recreate=true

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5516709382.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 25061.
recreate: true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants