-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Split out the common component between SuperUser and NonSuperUser form #25061
Conversation
…and non super user
/ok-to-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5453016962. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5453016962. |
Please generate a DP and test it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/build-deploy-preview recreate=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5455054146. |
Deploy-Preview-URL: https://ce-25061.dp.appsmith.com |
/build-deploy-preview recreate=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5516709382. |
Split out the common component between SuperUser and NonSuperUser form
PR fixes following issue(s)
Fixes # #24120
Media
Type of change
Testing
How Has This Been Tested?
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity:
Test Plan Approved
label after Cypress tests were reviewedTest Plan Approved
label after JUnit tests were reviewed