Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Query missing in AUTO_COMPLETE_SHOW event #24898

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Conversation

Druthi
Copy link
Contributor

@Druthi Druthi commented Jun 28, 2023

Description

Query missing in AUTO_COMPLETE_SHOW event

PR fixes following issue(s)

Fixes #23838

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@Druthi Druthi requested a review from rishabhrathod01 June 28, 2023 07:30
@Druthi
Copy link
Contributor Author

Druthi commented Jun 28, 2023

/ok-to-test

@github-actions github-actions bot added Autocomplete Issues related to the autocomplete Javascript Product Issues related to users writing javascript in appsmith Task A simple Todo labels Jun 28, 2023
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5398435600.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24898.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24898&runId=5398435600_1

@github-actions github-actions bot added the Bug Something isn't working label Jun 28, 2023
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5398435600.
Commit: ``.
Cypress dashboard: <a href="cypress_url=https://cloud.cypress.io/projects/eyxvp8/runs/36793" target="_blank"> Click here! </a>
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Sanity/Datasources/Airtable_Basic_Spec.ts

To know the list of identified flaky tests - Refer here

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5398435600.
Commit: ``.
Cypress dashboard url: <a href="cypress_url=https://cloud.cypress.io/projects/eyxvp8/runs/36793" target="_blank">Click here!</a>
All cypress tests have passed 🎉🎉🎉

@Druthi
Copy link
Contributor Author

Druthi commented Jun 28, 2023

/ok-to-test

@Druthi Druthi requested a review from rishabhrathod01 June 28, 2023 10:03
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5399817644.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24898.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24898&runId=5399817644_1

@Druthi
Copy link
Contributor Author

Druthi commented Jun 28, 2023

/ok-to-test

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5399904862.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24898.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24898&runId=5399904862_1

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5399904862.
Commit: ``.
Cypress dashboard url: <a href="cypress_url=https://cloud.cypress.io/projects/eyxvp8/runs/36807" target="_blank">Click here!</a>
All cypress tests have passed 🎉🎉🎉

@Druthi
Copy link
Contributor Author

Druthi commented Jul 5, 2023

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5462521859.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24898.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24898&runId=5462521859_1

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5462521859.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@Druthi Druthi requested a review from rishabhrathod01 July 5, 2023 10:57
@Druthi
Copy link
Contributor Author

Druthi commented Jul 5, 2023

/build-deploy-preview skip-tests=true env=release

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5463459538.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: release.
PR: 24898.
recreate: .

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Deploy-Preview-URL: https://appsmith-69aj8hflo-get-appsmith.vercel.app

@Druthi
Copy link
Contributor Author

Druthi commented Jul 5, 2023

/ok-to-test

@Druthi
Copy link
Contributor Author

Druthi commented Jul 5, 2023

/build-deploy-preview skip-tests=true env=release

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5464375093.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24898.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24898&runId=5464375093_1

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5464376407.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: release.
PR: 24898.
recreate: .

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Deploy-Preview-URL: https://appsmith-r7yzd6ni1-get-appsmith.vercel.app

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5464375093.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

Copy link
Contributor

@rishabhrathod01 rishabhrathod01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Druthi Druthi merged commit 499de5a into release Jul 5, 2023
@Druthi Druthi deleted the fix/auto-event branch July 5, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Autocomplete Issues related to the autocomplete Bug Something isn't working Javascript Product Issues related to users writing javascript in appsmith Task A simple Todo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Measure Autocomplete Effectiveness
2 participants