Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Action selector form getting cut off #24895

Merged
merged 2 commits into from
Jul 6, 2023
Merged

fix: Action selector form getting cut off #24895

merged 2 commits into from
Jul 6, 2023

Conversation

Druthi
Copy link
Contributor

@Druthi Druthi commented Jun 28, 2023

Description

fix: Action selector form getting cut off

PR fixes following issue(s)

Fixes #24369

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@Druthi Druthi requested a review from rishabhrathod01 June 28, 2023 06:23
@github-actions github-actions bot added Action Selector Issues related to action selector on the property pane Bug Something isn't working Javascript Product Issues related to users writing javascript in appsmith Medium Issues that frustrate users due to poor UX Production UI Improvement labels Jun 28, 2023
@Druthi
Copy link
Contributor Author

Druthi commented Jun 28, 2023

/ok-to-test

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5397934811.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24895.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24895&runId=5397934811_1

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5397934811.
Commit: ``.
Cypress dashboard: <a href="cypress_url=https://cloud.cypress.io/projects/eyxvp8/runs/36791" target="_blank"> Click here! </a>
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js

To know the list of identified flaky tests - Refer here

@Druthi
Copy link
Contributor Author

Druthi commented Jul 4, 2023

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5449764041.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24895.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24895&runId=5449764041_1

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5449764041.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/Apps/MongoDBShoppingCart_spec.ts

  2. cypress/e2e/Regression/ClientSide/ActionExecution/NavigateTo2_spec.ts
  3. cypress/e2e/Regression/ClientSide/AppNavigation/Sidebar_spec.js
  4. cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts
  5. cypress/e2e/Regression/ClientSide/CodeComment/PropertyPaneCodeComment_spec.ts
  6. cypress/e2e/Regression/ClientSide/ExplorerTests/Datasource_Structure_spec.js
  7. cypress/e2e/Regression/ClientSide/ExplorerTests/Widgets_spec.js
  8. cypress/e2e/Regression/ClientSide/JSObject/JSObjectMutation_spec.ts
  9. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ConversionFlow_Corner_Cases_spec.ts
  10. cypress/e2e/Regression/ClientSide/PropertyPane/PropertyPane_Search_spec.ts
  11. cypress/e2e/Regression/ClientSide/Widgets/Checkbox/CheckBoxLintErrorMultipleRowValidation_spec.js
  12. cypress/e2e/Regression/ClientSide/Widgets/ListV2/Listv2_onItemClick_spec.js
  13. cypress/e2e/Regression/ClientSide/Widgets/Multiselect/Multi_Select_Tree_spec.js
  14. cypress/e2e/Sanity/Datasources/MySQL_spec.js
To know the list of identified flaky tests - Refer here

@Druthi
Copy link
Contributor Author

Druthi commented Jul 4, 2023

/build-deploy-preview skip-tests=true env=release

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5450469275.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: release.
PR: 24895.
recreate: .

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5449764041.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Deploy-Preview-URL: https://appsmith-cd5cf5gr1-get-appsmith.vercel.app

@ramsaptami ramsaptami requested a review from shwetha-ramesh July 4, 2023 10:47
@shwetha-ramesh
Copy link

@Druthi Working as expected.
At 100% zoom
image

@ramsaptami ramsaptami added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Jul 6, 2023
@Druthi Druthi merged commit 5ef23fc into release Jul 6, 2023
@Druthi Druthi deleted the fix/slash-com branch July 6, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhrathod01 rishabhrathod01 rishabhrathod01 approved these changes

@shwetha-ramesh shwetha-ramesh Awaiting requested review from shwetha-ramesh

Assignees
No one assigned
Labels
Action Selector Issues related to action selector on the property pane Bug Something isn't working Javascript Product Issues related to users writing javascript in appsmith Medium Issues that frustrate users due to poor UX Production Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable UI Improvement
Projects
None yet
Milestone
No milestone
4 participants
@Druthi @shwetha-ramesh @rishabhrathod01 @ramsaptami