Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes error count form widget name component #24653

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

aswathkk
Copy link
Contributor

@aswathkk aswathkk commented Jun 20, 2023

Description

Removes the error count form the widget name

PR fixes following issue(s)

Fixes #22892

if no issue exists, please create an issue and ask the maintainers about this first

Media

before:

after:
Screenshot 2023-06-20 at 10 50 58 AM

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Bug Something isn't working Canvas / Grid Issues related to the canvas Needs Triaging Needs attention from maintainers to triage Production UI Building Product Issues related to the UI Building experience UI Improvement Anvil Pod Issue related to Anvil project Widget Styling and removed Bug Something isn't working labels Jun 20, 2023
@aswathkk aswathkk changed the title removes error count form widget name component fix: removes error count form widget name component Jun 20, 2023
@aswathkk
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5318848291.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24653.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24653&runId=5318848291_1

@github-actions github-actions bot added Bug Something isn't working and removed Bug Something isn't working labels Jun 20, 2023
@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5318848291.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Widget_Error_spec.js

  2. cypress/e2e/Regression/ServerSide/OnLoadTests/JsOnLoad3_Spec.ts
To know the list of identified flaky tests - Refer here

@aswathkk
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5319477971.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24653.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24653&runId=5319477971_1

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5319477971.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js

To know the list of identified flaky tests - Refer here

@aswathkk aswathkk requested a review from marks0351 June 20, 2023 09:15
@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5319477971.
Commit: ``.
All cypress tests have passed 🎉

@aswathkk
Copy link
Contributor Author

/build-deploy-preview env=release

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5349275571.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 24653.
recreate: .

@github-actions
Copy link

Deploy-Preview-URL: https://appsmith-g0gobpmcx-get-appsmith.vercel.app

@github-actions
Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Jun 30, 2023
@aswathkk aswathkk removed the Stale label Jul 4, 2023
@kamakshibhat-appsmith
Copy link

kamakshibhat-appsmith commented Jul 4, 2023

Can we merge latest release and also check whether we are pointing to latest cloud service? The convert to auto layout options are not available in the DP hence suspecting the old endpoint.
@rahulramesha Can you help with this as @aswathkk is not available atm ?

@aswathkk aswathkk requested a review from a team July 4, 2023 11:23
@aswathkk
Copy link
Contributor Author

aswathkk commented Jul 4, 2023

/build-deploy-preview env=release

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5454127395.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 24653.
recreate: .

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Deploy-Preview-URL: https://appsmith-odg70ewfv-get-appsmith.vercel.app

@kamakshibhat-appsmith
Copy link

LGTM ! We can merge

@aswathkk
Copy link
Contributor Author

aswathkk commented Jul 4, 2023

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5455346991.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24653.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24653&runId=5455346991_1

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5455346991.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Git/GitDiscardChange/DiscardChanges_spec.js

  2. cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts
To know the list of identified flaky tests - Refer here

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5455346991.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5455346991.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@aswathkk aswathkk merged commit b48e339 into release Jul 5, 2023
@aswathkk aswathkk deleted the fix/remove-error-count branch July 5, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anvil Pod Issue related to Anvil project Bug Something isn't working Canvas / Grid Issues related to the canvas Needs Triaging Needs attention from maintainers to triage Production UI Building Product Issues related to the UI Building experience UI Improvement Widgets Product This label groups issues related to widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Remove error number from the widget name component
3 participants