Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor Auto Layout min/max dimension for widgets #24627

Merged
merged 13 commits into from
Jul 4, 2023

Conversation

aswathkk
Copy link
Contributor

@aswathkk aswathkk commented Jun 19, 2023

Description

AutoLayout specific widget logic such as setting min/max dimension is set by making use of a global class .auto-layout that is set in the main canvas. This leaks the idea of platform specific construct "auto-layout" into widget component.

This PR resolves that by making use of necessary props to the widget component

PR fixes following issue(s)

Fixes #24492

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

  • Refactor

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@aswathkk aswathkk marked this pull request as draft June 19, 2023 12:23
@github-actions github-actions bot added Responsive Widget UI Building Product Issues related to the UI Building experience labels Jun 19, 2023
@aswathkk aswathkk force-pushed the refactor/min-max-dimension branch from 34942f6 to 5ee5b24 Compare June 20, 2023 11:55
@aswathkk aswathkk marked this pull request as ready for review June 22, 2023 07:04
@aswathkk aswathkk requested review from a team, berzerkeer and marks0351 and removed request for a team June 22, 2023 07:04
@aswathkk
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5344222098.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24627.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24627&runId=5344222098_1

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5344222098.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js

  2. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoDimension_1_spec.ts
  3. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoDimension_2_spec.ts
To know the list of identified flaky tests - Refer here

marks0351
marks0351 previously approved these changes Jun 23, 2023
@aswathkk aswathkk changed the title Refactor/min max dimension refactor: Refactor Auto Layout min/max dimension for widgets Jun 23, 2023
@aswathkk
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5353625817.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24627.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24627&runId=5353625817_1

@aswathkk
Copy link
Contributor Author

/build-deploy-preview env=release

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5353677057.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 24627.
recreate: .

@github-actions
Copy link

Deploy-Preview-URL: https://appsmith-3zm05o1td-get-appsmith.vercel.app

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5353625817.
Commit: ``.
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js

To know the list of identified flaky tests - Refer here

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5353625817.
Commit: ``.
All cypress tests have passed 🎉

@aswathkk aswathkk requested a review from marks0351 June 23, 2023 12:32
@berzerkeer berzerkeer requested review from sbalaji1192 and removed request for berzerkeer June 28, 2023 05:35
@aswathkk aswathkk removed the request for review from sbalaji1192 June 29, 2023 05:28
@aswathkk aswathkk merged commit 6b8e61d into release Jul 4, 2023
@aswathkk aswathkk deleted the refactor/min-max-dimension branch July 4, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Building Product Issues related to the UI Building experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Refactor min/max dimension implementaion
2 participants