-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor Auto Layout min/max dimension for widgets #24627
Conversation
34942f6
to
5ee5b24
Compare
/ok-to-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5344222098. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5344222098.
|
/ok-to-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5353625817. |
/build-deploy-preview env=release |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5353677057. |
Deploy-Preview-URL: https://appsmith-3zm05o1td-get-appsmith.vercel.app |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5353625817.
To know the list of identified flaky tests - Refer here |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5353625817. |
Description
AutoLayout specific widget logic such as setting min/max dimension is set by making use of a global class .auto-layout that is set in the main canvas. This leaks the idea of platform specific construct "auto-layout" into widget component.
This PR resolves that by making use of necessary props to the widget component
PR fixes following issue(s)
Fixes #24492
Media
Type of change
Testing
How Has This Been Tested?
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity:
Test Plan Approved
label after Cypress tests were reviewedTest Plan Approved
label after JUnit tests were reviewed