feat: Configurable api server timeout on embedded nginx

[sum35h]

Description

• The default request timeout on nginx is set to 60s. This feat allows users to configure custom nginx timeout value specified via the Environment variable APPSMITH_SERVER_TIMEOUT
• Solves [Feature]: Increasing timeout on internal nginx #14535

Testing

How Has This Been Tested?

• Manual
• Jest
• Cypress

[sum35h]

/build-deploy-preview skipTests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5270272390.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 24471.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-24471.dp.appsmith.com

[sum35h]

/ok-to-test

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5333899127.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24471.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24471&runId=5333899127_1

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5333899127.
Commit: ``.
The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js

To know the list of identified flaky tests - Refer here

[sharat87]

I wanted to confirm if a long-running API call can be made in the DP, but the DP seems to be down. Can you check please? Can you also review the below and share you thoughts?

From http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_read_timeout

The timeout is set only between two successive read operations, not for the transmission of the whole response.

So, the effective timeout from setting this can be much longer. Is this what we're expecting here?

From http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_connect_timeout,

[...] timeout for establishing a connection with a proxied server.

This is the time for just establishing the connection, and shouldn't affect timeouts from long-running queries, right?

From http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_send_timeout,

[...] timeout for transmitting a request to the proxied server.

This is timeout between adjacent bytes of data sent to the backend. This is also not what we want here, right?

Also, the default value for all three from docs is shown as 60s, not 60. Does it work without the s as well?

[sum35h]

@sharat87 The configs work without specifying seconds.

• proxy_connect_timeout - is not required to increase the query time out.
• proxy_read_timeout - does actually increase the query timeout despite the description, so this will be required.
• proxy_write_timeout - did not try this but I think it will increase timeout for post/put, so it would alos be required?

[sharat87]

Tested and works. Made suggestions for some whitespace cleanup, but otherwise ready to merge.

[sum35h]

/ok-to-test

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5444864297.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24471.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24471&runId=5444864297_1

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5444864297.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoFillWidgets_Reflow_spec.ts

To know the list of identified flaky tests - Refer here

[sum35h]

/ok-to-test

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5450871447.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24471.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24471&runId=5450871447_1

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5450871447.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

[shalomy-cyera]

@sum35h Thanks for this fix!
Will it be available also for helm install?

[sum35h]

@shalomy-cyera For the helm deployment, we'll need to apply the same settings to the ingress controller. We will update you once we publish the docs to apply the setting to helm installations.

[shalomy-cyera]

@shalomy-cyera For the helm deployment, we'll need to apply the same settings to the ingress controller. We will update you once we publish the docs to apply the setting to helm installations.

Thanks a lot @sum35h !

[tlawrence-TAG]

You need to add configuration settings to the UI