Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Overriding the import @appsmith eslint rule on EE folder #24228

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented Jun 8, 2023

Description

Overriding the import @AppSmith eslint rule on EE folder

PR fixes following issue(s)

Fixes #24183

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

  • Manual
  • Jest
  • Cypress

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@what-the-diff
Copy link

what-the-diff bot commented Jun 8, 2023

PR Summary

  • Removal of .eslintrc file in the ee directory
    The .eslintrc configuration file located in the ee directory was removed.

  • New restricted imports rule added
    A rule for restricted imports was added to the .eslintrc file in the app/client/ directory, applying only to files under the /ee//* path. This rule filters out any rules specifically related to the ce code (those with a group of "**/ce/*").

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jun 8, 2023
@github-actions github-actions bot added Business Edition Features that will be a part of our business edition Task A simple Todo Platform Administration Pod Issues related to platform administration & management labels Jun 8, 2023
@mohanarpit mohanarpit merged commit 51aa3b5 into release Jun 8, 2023
@mohanarpit mohanarpit deleted the chore/update-eslintrc branch June 8, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Business Edition Features that will be a part of our business edition Platform Administration Pod Issues related to platform administration & management skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add a check for @appsmith imports
3 participants