Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WDS color positive #24086

Merged
merged 2 commits into from
Jun 15, 2023
Merged

feat: WDS color positive #24086

merged 2 commits into from
Jun 15, 2023

Conversation

ichik
Copy link
Contributor

@ichik ichik commented Jun 6, 2023

Description

tl;dr Checking whether seed falls into the interval and picking most distant green

Fixes #23803

Media

Screen.Recording.2023-06-14.at.14.41.19.mov

Type of change

  • New feature (non-breaking change which adds functionality)
  • Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?

  • Manual

Test Plan

Initial POC refinement, no testing necessary

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@ichik ichik added skip-changelog Adding this label to a PR prevents it from being listed in the changelog skip-testPlan WDS team labels Jun 6, 2023
@ichik ichik requested review from jsartisan, somangshu and KelvinOm June 6, 2023 10:57
@ichik ichik self-assigned this Jun 6, 2023
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Anvil Pod Issue related to Anvil project and removed skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Jun 6, 2023
@ichik ichik changed the title Feat/wds color positive feat: WDS color positive Jun 6, 2023
@github-actions github-actions bot added the Enhancement New feature or request label Jun 6, 2023
@somangshu somangshu removed their request for review June 6, 2023 11:41
@ichik ichik force-pushed the feat/wds-color-positive branch from 33c566b to 7724898 Compare June 13, 2023 14:02
@ichik ichik marked this pull request as ready for review June 14, 2023 12:43
}

return color;
}

private get fgOnAssistive() {
return this.bg.clone();
private get fgWarn() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private get fgWarn() {
private get fgWarning() {

@KelvinOm
Copy link
Collaborator

It looks like magic to me. I want to build an interface on all this and see how it will look. I mean to build some kind of complex form with controls and different statuses.

@KelvinOm KelvinOm merged commit 4d5859b into release Jun 15, 2023
@KelvinOm KelvinOm deleted the feat/wds-color-positive branch June 15, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anvil Pod Issue related to Anvil project Enhancement New feature or request WDS team Widgets Product This label groups issues related to widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: WDS semaphore positive color
2 participants