Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refined fgAccent (light mode), fixed missing return in fg (light mode) #23740

Merged
merged 1 commit into from
May 25, 2023
Merged

chore: Refined fgAccent (light mode), fixed missing return in fg (light mode) #23740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Refined fgAccent (light mode), fixed missing return in fg (light mode)
  • Loading branch information
@ichik
ichik committed May 25, 2023
commit 2fde229ffa3776c6ffc0926968b7b3b4e5be730e
8 changes: 4 additions & 4 deletions app/client/packages/design-system/theming/src/utils/TokensAccessor/LightModeTheme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,11 +224,11 @@ export class LightModeTheme implements ColorModeTheme {
if (this.seedIsAchromatic) {
color.oklch.l = 0.12;
color.oklch.c = 0;
return color;
}

color.oklch.l = 0.12;
color.oklch.c = 0.032;

return color;
}

Expand All @@ -237,13 +237,13 @@ export class LightModeTheme implements ColorModeTheme {

if (this.bg.contrastAPCA(this.seedColor) <= 60) {
if (this.seedIsAchromatic) {
color.oklch.l = 0.25;
color.oklch.l = 0.45;
color.oklch.c = 0;
return color;
}

color.oklch.l = 0.25;
color.oklch.c = 0.064;
color.oklch.l = 0.45;
color.oklch.c = 0.164;
return color;
}

Expand Down