-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: [#22155] Optional SSL support for Redshift plugin #22844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release
Are you sure you want to change the base?
feat: [#22155] Optional SSL support for Redshift plugin #22844
Conversation
{ | ||
"label": "Default", | ||
"value": "DEFAULT" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove:
(1) "hidden": true
This should make the SSL dropdown visible on the Redshift datasource config page.
(2) Options that do not apply e.g. verify-ca
, verify-full
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this @sumitsum
{ | ||
"label": "Default", | ||
"value": "DEFAULT" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a small screen recording in the description showing how this looks and works ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will try to do it in a day or two. Currently facing issues due to lack of enough resources. I saw some of the similar plugins having this <label, value> in form.json
Hi @harshmange44 are you still working on this ? |
Yes @sumitsum, regarding your query about the 'DEFAULT' config in form.json. I noticed one pattern, the postgres plugin also has the same 'DEFAULT' config (MySQL plugin recent changes as well). Shall we remove 'DEFAULT' from the Redshift plugin? Could you pls guide me here? |
Hi @harshmange44 , please let the default option stay. Default option means doing nothing from our side and leaving the config to the default driver behaviour. |
Description
Fixes #22155
Type of change
Checklist:
Dev activity
QA activity: