-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WIP - Add DynamicContainerWidget (#22796) #22797
feat: WIP - Add DynamicContainerWidget (#22796) #22797
Conversation
Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed. |
@iamenrique can you explain what is the problem you are trying to solve with this widget? |
@dilippitchika What I try to do is what I described in this thread a couple of days ago: I need the following layouts in my page:
I plan to have a single widget in each section, and that widget should take the whole space of the container (height and width). Unless you suggest a different approach, I'd try to solve it via a DynamicContainerWidget. Drop one of those in my page, extend it to take the whole page width and enough height, and place my contents in the sections. Currently it's using a blueprint to have the 3 Containers, each one with a Text widget (display "Panel A/B/C" respectively. |
@iamenrique checked the discord as well, but i have more questions
|
CC @andreevanatasha |
@dilippitchika I'm happy to answer.
|
Hey @iamenrique i still don't understand the need for having quite this dynamic master detail pattern. I get that once you select something in the master, the focus should be on the detail and that is why it should change dynamically. But having 3 layouts, overlays etc doesn't make sense to me yet. Nevertheless, we think it's better if you fork a version of Appsmith and add the widget there so that you can use it but i don't think we can add and maintain the widget right now. We will soon open anyone to contribute custom widget #2033 so that you can add this widget without forking. Really appreciate your contribution, we will launch our custom widgets feature soon. |
Description
Please, let me know if progress so far is correct. @dilippitchika @riodeuno @Nikhil-Nandagopal
Fixes #22796
Media
https://watch.screencastify.com/v/svt9jNI7ZHTxyzWcRzy3
Type of change
How Has This Been Tested?
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity: