Skip to content

poc: vertical alignment #21720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 914 commits into
base: release
Choose a base branch
from
Open

poc: vertical alignment #21720

wants to merge 914 commits into from

Conversation

yaldram
Copy link
Contributor

@yaldram yaldram commented Mar 23, 2023

Description

  • Added alignment bottom to the widgets.

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

marks0351 and others added 30 commits February 21, 2023 17:08
@marks0351
enabling dynamic height under the hood for autolayout.
c67c5e7
@marks0351
add Canvas Resizer.
60d4b33
@marks0351
Adding alignment based resizing behaviour for autolayout.
e350a2e
@aswathkk
feat: Responsive Checkbox & Switch Widgets (#19999)
4e98bd0 
Sets minWidth to Checkbox & Switch widgets.
Label overflow behaviour updated for autoLayout
@aswathkk
Feat: Responsive select widgets (#19985)
816e6f3 
Adds minWidth config for Select, MuliSelect, TreeSelect, MultiSelectTree
widgets.
Removes label position and font size properties too from those widgets
for AutoLayout.
fix: Jest tests
91c0276
Updates widget config according to spec
0d1c31a
@prsidhu
minor fix
6456a04
@prsidhu
Merge remote-tracking branch 'origin/release' into mobile/v1/main
a38a194
fix: infinite loop in jest test
b10ca47
Merge branch 'mobile/v1/main' into feat/widget_responsiveness
a94c0e8
Fix Auto layout bugs #20694, #20704, #20696
dfca434
@prsidhu
fix global hot keys test
1a704cb
Merge branch 'mobile/v1/main' into feat/widget_responsiveness
6f56418
@prsidhu
remove unused import
bc71f0a
pull from main barnch and resolve conflicts
055e0e8
@marks0351
removing console logs.
e757c42
@marks0351
Revert "enabling dynamic height under the hood for autolayout."
3f1be90 
This reverts commit c67c5e7.
pull from mobile QA branch and resolve conflicts
784ef4e
fix canvasResizer width related bugs
0c35b4d
pull from mobile QA branch and resolve conflicts
867e710
@marks0351
Adjust widget name component border.
c1499c4
@marks0351
adjust resize handles position.
d1c9fb5
@marks0351
select new widget on drop in auto layout mode.
e1ac2e0
@prsidhu
cleanup resizable component and remove additionalAction
aecd8a6
@prsidhu
move widgetTypeClassname to widgetUtils
250619c
@prsidhu
memoize flexbox style
1479e2d
@prsidhu
Merge branch 'mobile/v1/refactor' into mobile/v1/main
33cae06
wip: tried to use updateMultipleWidgetPropertiesAction
d69dc3e
Merge branch 'mobile/v1/main' into feat/widget_responsiveness
105c76b
marks0351 and others added 19 commits March 21, 2023 11:24
@marks0351
fixing resizing css based glitch.
c1e3ff7
@marks0351
disable resize handle dots while canvas is resizing.
165c946
@marks0351
Remove App positioning control.
26a6156
@marks0351
display canvas size only fixed layout.
7638727
@marks0351
Re enable canvas scroll.
f3ff076
@marks0351
fix scroll not showing up in deploy mode.
d31a9ac
@marks0351
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
9abbd57 
…o mobile/v1/main
@marks0351
Release merge fixes.
7adacc1
@marks0351
Merge branch 'mobile/v1/main' of https://github.com/appsmithorg/appsmith
c142683 
 into mobile/v1/qa
fix restore snapshot flow, by updating appPositioning type
00dc05b
implement widthInPercentage while converting by using positionUtils
69ef081
Merge branch 'mobile/v1/qa' of github.com:appsmithorg/appsmith into m…
9b05b1b 
…obile/v1/qa
prevent saving snapshot for single empty page
4f660ef
prevent recalculating columns while converting or using snapshot
cc6ff11
updates widget configs
99c3e1c
fix: resized widgets gets back to original size & widget config updates
c6fdcaa
fix: infinite update on auto dimension
f865200
udpates widget config from Widgets in Stacks doc
df26d0c
@yaldram
feat: added vertical alignment bottom to widgets.
7d65f6e
@yaldram
Copy link
Contributor Author

yaldram commented Mar 23, 2023

/build-deploy-preview env=release

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4498886812.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 21720.

1 similar comment
@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4498886812.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 21720.

@github-actions
Copy link

Deploy-Preview-URL: https://appsmith-f5bppcmxz-get-appsmith.vercel.app

@yaldram
Copy link
Contributor Author

yaldram commented Mar 23, 2023

/build-deploy-preview env=release

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4500237047.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 21720.

@github-actions
Copy link

Deploy-Preview-URL: https://appsmith-fcowbvpn3-get-appsmith.vercel.app

@github-actions
Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Mar 30, 2023
Base automatically changed from mobile/v1/qa to release April 7, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaldram @marks0351 @aswathkk @prsidhu