Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 'Form.hasChanges' showing lint error #20960

Merged
merged 4 commits into from
Mar 9, 2023
Merged

fix: 'Form.hasChanges' showing lint error #20960

merged 4 commits into from
Mar 9, 2023

Conversation

ohansFavour
Copy link
Contributor

@ohansFavour ohansFavour commented Feb 25, 2023 •
edited
Loading

Description

This PR adds meta actions to the list of actions that can trigger linting.

Fixes #21051

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@vercel
Copy link

vercel bot commented Feb 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
appsmith ❌ Failed (Inspect) Mar 3, 2023 at 10:43AM (UTC)

@ohansFavour
Copy link
Contributor Author

/ok-to-test sha=36c89c9

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4269530951.
Workflow: Appsmith External Integration Test Workflow.
Commit: 36c89c9.
PR: 20960.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20960&runId=4269530951_1

@github-actions
Copy link

The following are new failures, please fix them before merging the PR
  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_BasicServerSideData_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_spec.js

@github-actions
Copy link

The following are new failures, please fix them before merging the PR
  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_BasicServerSideData_spec.js

@github-actions
Copy link

The following are new failures, please fix them before merging the PR
  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_BasicServerSideData_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_spec.js

@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Bug Something isn't working Form Widget Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage and removed Bug Something isn't working labels Feb 27, 2023
@ohansFavour ohansFavour changed the title Fix: 'Form.hasChanges' showing lint error fix: 'Form.hasChanges' showing lint error Feb 27, 2023
@github-actions github-actions bot added the Bug Something isn't working label Feb 27, 2023
@ohansFavour
Copy link
Contributor Author

/build-deploy-preview

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4280598556.
Workflow: On demand build Docker image and deploy preview.
PR: 20960.

@github-actions
Copy link

Deploy-Preview-URL: https://ce-20960.dp.appsmith.com

@github-actions github-actions bot added Javascript Product Issues related to users writing javascript in appsmith JS Linting & Errors Issues related to JS Linting and errors labels Feb 28, 2023
@ramsaptami
Copy link
Contributor

Verified fixes for the 2 PRs mentioned cc: @ohansFavour

rishabhrathod01
rishabhrathod01 previously approved these changes Mar 2, 2023
View reviewed changes
@ohansFavour
Copy link
Contributor Author

/perf-test

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4313838583.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 20960.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20960&runId=4313838583_1

@ohansFavour ohansFavour added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Mar 2, 2023
@ohansFavour
Copy link
Contributor Author

/ok-to-test sha=0bb8c57

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4322478750.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0bb8c57.
PR: 20960.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20960&runId=4322478750_1

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

The following are new failures, please fix them before merging the PR
  1. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_BasicServerSideData_spec.js

@ohansFavour
Copy link
Contributor Author

/ok-to-test sha=cc2d75e

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4367781343.
Workflow: Appsmith External Integration Test Workflow.
Commit: cc2d75e.
PR: 20960.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20960&runId=4367781343_1

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

The following are new failures, please fix them before merging the PR
  1. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_BasicServerSideData_spec.js

rishabhrathod01
rishabhrathod01 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ohansFavour ohansFavour merged commit 3b5b24d into release Mar 9, 2023
@ohansFavour ohansFavour deleted the fix/add-meta-to-lint-actions branch March 9, 2023 07:12
@ohansFavour ohansFavour mentioned this pull request Mar 10, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhrathod01 rishabhrathod01 rishabhrathod01 approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Form Widget Javascript Product Issues related to users writing javascript in appsmith JS Linting & Errors Issues related to JS Linting and errors Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: False positive lint error when form.hasChanges is bound to a data field
3 participants
@ohansFavour @ramsaptami @rishabhrathod01