chore: Move Maps API Key to database #20771

sharat87 · 2023-02-20T06:26:11Z

Changing the Maps API Key doesn't need restart anymore.
The isRestartRequired field in the response of updating env settings, was being ignored. The client owns the decision of when to restart (which is correct), so removed this from the server.
Write Maps API Key to the database, in the tenant configuration.
The Settings page for Maps Ke gets the current value from /tenant/current response, and not /admin/env.
Removed APPSMITH_GOOGLE_MAPS_API_KEY from /admin/env response.
Tests.

DO NOT MERGE. Please only review/approve. This is expected to break EE once it goes there, which I intend to solve alongside merging this.

Changing the Maps API Key will update it both in the tenant config in the database, as well as in the docker.env file. This is predominantly for backwards compatibility, and phased rollout. As part of a separate PR, we'll have a migration that proactively copies the env variable value to the database, and comment out the value in the docker.env file. Then we can stop updating the docker.env file as well.

New

Old

vercel · 2023-02-20T06:26:15Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
appsmith	⬜️ Ignored (Inspect)			Feb 26, 2023 at 8:54AM (UTC)

…controllers/ce/TenantControllerCE.java

…into chore/maps-key-without-restart

sharat87 · 2023-02-25T01:28:06Z

/ok-to-test sha=4dd2da0

github-actions · 2023-02-25T01:28:34Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4267650663.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4dd2da0.
PR: 20771.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20771&runId=4267650663_1

github-actions · 2023-02-25T02:36:14Z

The following are new failures, please fix them before merging the PR

cypress/integration/Regression_TestSuite/ClientSideTests/EmbedSettings/EmbedSettings_spec.js cypress/integration/Regression_TestSuite/ClientSideTests/FormLogin/EnableFormLogin_spec.js cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/RegenerateSSHKey_spec.js cypress/integration/Regression_TestSuite/ClientSideTests/Github/EnableGithub_spec.js cypress/integration/Regression_TestSuite/ClientSideTests/Google/EnableGoogle_spec.js cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_BasicServerSideData_spec.js cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_spec.js cypress/integration/Regression_TestSuite/UpgradeAppsmith/UpgradeAppsimth_spec.js

sharat87 · 2023-02-25T03:57:29Z

/ok-to-test sha=ddb544c

github-actions · 2023-02-25T03:57:52Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4268225450.
Workflow: Appsmith External Integration Test Workflow.
Commit: ddb544c.
PR: 20771.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20771&runId=4268225450_1

github-actions · 2023-02-25T05:04:37Z

The following are new failures, please fix them before merging the PR

cypress/integration/Regression_TestSuite/ClientSideTests/EmbedSettings/EmbedSettings_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/FormLogin/EnableFormLogin_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Github/EnableGithub_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Google/EnableGoogle_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Chart/Chart_Widget_Loading_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_spec.js

sharat87 · 2023-02-26T09:34:13Z

/ok-to-test sha=94fc749

github-actions · 2023-02-26T09:34:39Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4274357703.
Workflow: Appsmith External Integration Test Workflow.
Commit: 94fc749.
PR: 20771.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20771&runId=4274357703_1

sharat87 · 2023-07-18T08:08:08Z

Cypress tests have actually all passed. The failure is due to this:

Here's Cypress dashboard:

…o chore/maps-key-without-restart

ankitakinger · 2023-07-18T13:12:43Z

/ok-to-test

github-actions · 2023-07-18T13:13:08Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5587891428.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 20771.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20771&runId=5587891428_1

github-actions · 2023-07-18T14:21:43Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5587891428.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js
cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2023-07-18T15:35:01Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5587891428.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

ankitakinger

FE changes looks good to me

sharat87 · 2023-07-19T01:45:03Z

/build-deploy-preview

github-actions · 2023-07-19T01:45:29Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5594103452.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 20771.
recreate: .

github-actions · 2023-07-19T02:14:30Z

Deploy-Preview-URL: https://ce-20771.dp.appsmith.com

sharat87 · 2023-07-19T05:15:09Z

Changing the Maps key crashes frontend. 😭

shot-2023-07-19-04-22-22.mp4

Slack thread here.

sharat87 · 2023-07-21T07:09:29Z

/ok-to-test

github-actions · 2023-07-21T07:09:57Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5619645138.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 20771.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20771&runId=5619645138_1

github-actions · 2023-07-21T08:42:01Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5619645138.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/BugTests/DatasourceSchema_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApplicationURL_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2023-07-21T09:44:31Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5619645138.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

...rver/appsmith-server/src/main/java/com/appsmith/server/domains/ce/TenantConfigurationCE.java

sharat87 added 2 commits February 20, 2023 10:09

chore: Set maps key without restart

00cb432

Remove maps key from /admin/env

0c9513f

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Feb 20, 2023

sharat87 and others added 6 commits February 21, 2023 09:41

Use component-page for Maps settings

b114e6e

Remove needsRestart changes, not needed

92ce9c9

Restore app/server/appsmith-server/src/main/java/com/appsmith/server/…

4a2cbf3

…controllers/ce/TenantControllerCE.java

Remove useless boolean response

69af936

Merge remote-tracking branch 'origin/chore/maps-key-without-restart' …

9b7a9f2

…into chore/maps-key-without-restart

Merge branch 'release' into chore/maps-key-without-restart

43181b3

vercel bot had a problem deploying to Preview February 21, 2023 07:15 Failure

sharat87 added 2 commits February 22, 2023 07:42

Add tests for maps key

1b8c575

Merge branch 'release' into chore/maps-key-without-restart

c7ca322

sharat87 marked this pull request as ready for review February 22, 2023 02:38

vercel bot had a problem deploying to Preview February 22, 2023 02:41 Failure

Merge branch 'release' into chore/maps-key-without-restart

4dd2da0

vercel bot had a problem deploying to Preview February 24, 2023 16:52 Failure

sharat87 added 2 commits February 25, 2023 07:30

Fix maps input width

faefe7c

Fix some test keys

ddb544c

vercel bot had a problem deploying to Preview February 25, 2023 03:40 Failure

Fix font weight

8d0ed94

Fix empty response from PUT /admin/env

94fc749

sharat87 added skip-changelog Adding this label to a PR prevents it from being listed in the changelog and removed skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Jul 18, 2023

ankitakinger added 2 commits July 18, 2023 18:39

updating only tenant cnfig condition

8002d28

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

1cb3681

…o chore/maps-key-without-restart

ankitakinger previously approved these changes Jul 18, 2023

View reviewed changes

sharat87 added 3 commits July 20, 2023 10:27

Merge branch 'release' into chore/maps-key-without-restart

c6a0688

Introducing "Save & Refresh"!

70e7236

Merge release

d2a5404

sharat87 dismissed ankitakinger’s stale review via d2a5404 July 21, 2023 06:41

ankitakinger previously approved these changes Jul 21, 2023

View reviewed changes

Allow null in getClientPertinentTenant, used in EE

4d05a25

sharat87 dismissed ankitakinger’s stale review via 4d05a25 July 21, 2023 10:02

sharat87 requested a review from nidhi-nair July 21, 2023 10:13

nidhi-nair reviewed Jul 21, 2023

View reviewed changes

...rver/appsmith-server/src/main/java/com/appsmith/server/domains/ce/TenantConfigurationCE.java Show resolved Hide resolved

nidhi-nair approved these changes Jul 21, 2023

View reviewed changes

sharat87 merged commit 3129e88 into release Jul 24, 2023

sharat87 deleted the chore/maps-key-without-restart branch July 24, 2023 08:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Move Maps API Key to database #20771

chore: Move Maps API Key to database #20771

sharat87 commented Feb 20, 2023 •

edited

Loading

vercel bot commented Feb 20, 2023 •

edited

Loading

sharat87 commented Feb 25, 2023

github-actions bot commented Feb 25, 2023

github-actions bot commented Feb 25, 2023

sharat87 commented Feb 25, 2023

github-actions bot commented Feb 25, 2023

github-actions bot commented Feb 25, 2023

sharat87 commented Feb 26, 2023

github-actions bot commented Feb 26, 2023

sharat87 commented Jul 18, 2023

ankitakinger commented Jul 18, 2023

github-actions bot commented Jul 18, 2023

github-actions bot commented Jul 18, 2023

github-actions bot commented Jul 18, 2023

ankitakinger left a comment

sharat87 commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

sharat87 commented Jul 19, 2023

sharat87 commented Jul 21, 2023

github-actions bot commented Jul 21, 2023

github-actions bot commented Jul 21, 2023

github-actions bot commented Jul 21, 2023

chore: Move Maps API Key to database #20771

chore: Move Maps API Key to database #20771

Conversation

sharat87 commented Feb 20, 2023 • edited Loading

New

Old

vercel bot commented Feb 20, 2023 • edited Loading

sharat87 commented Feb 25, 2023

github-actions bot commented Feb 25, 2023

github-actions bot commented Feb 25, 2023

sharat87 commented Feb 25, 2023

github-actions bot commented Feb 25, 2023

github-actions bot commented Feb 25, 2023

sharat87 commented Feb 26, 2023

github-actions bot commented Feb 26, 2023

sharat87 commented Jul 18, 2023

ankitakinger commented Jul 18, 2023

github-actions bot commented Jul 18, 2023

github-actions bot commented Jul 18, 2023

github-actions bot commented Jul 18, 2023

ankitakinger left a comment

Choose a reason for hiding this comment

sharat87 commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

sharat87 commented Jul 19, 2023

sharat87 commented Jul 21, 2023

github-actions bot commented Jul 21, 2023

github-actions bot commented Jul 21, 2023

github-actions bot commented Jul 21, 2023

sharat87 commented Feb 20, 2023 •

edited

Loading

vercel bot commented Feb 20, 2023 •

edited

Loading