feat: [APPSMTH-29] make step up/down arrows in input Number and Currency widgets optional #18764

ghost · 2022-12-07T18:15:41Z

Description

This PR makes step up/down arrows optional in

CurrencyInput
Input

NB: This would require updating the Appsmith Documentation

Fixes #18041

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

Cypress Tests

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

…ptional

vercel · 2022-12-07T18:15:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	Dec 21, 2022 at 0:40AM (UTC)

app/client/src/widgets/CurrencyInputWidget/widget/index.tsx

app/client/src/widgets/constants.ts

app/client/src/widgets/InputWidgetV2/widget/index.tsx

app/client/src/widgets/CurrencyInputWidget/widget/index.tsx

…thub.com/appsmithorg/appsmith into APPSMTH-29

sbalaji1192 · 2022-12-13T11:12:53Z

app/client/src/utils/migrations/InputWidgetMigrations.ts

+): DSLWidget => {
+  return traverseDSLAndMigrate(currentDSL, (widget: WidgetProps) => {
+    if (
+      widget.showStepArrows === undefined &&


let's swap the operand positions of and condition

Could you move this function to the CurrencyInputWidgetMigrations.test.ts file?

sbalaji1192 · 2022-12-13T11:16:23Z

app/client/src/widgets/BaseInputWidget/constants.ts

@@ -6,3 +6,9 @@ export enum InputTypes {
  PASSWORD = "PASSWORD",
  CURRENCY = "CURRENCY",
 }
+
+export enum ButtonPosition {


Can we please rename this to NumberInputStepButtonPosition. ButtonPosition seems to be misleading.

sbalaji1192 · 2022-12-13T11:20:18Z

app/client/src/widgets/CurrencyInputWidget/widget/index.tsx

@@ -430,6 +431,12 @@ class CurrencyInputWidget extends BaseInputWidget<
      conditionalProps.errorMessage = createMessage(FIELD_REQUIRED_ERROR);
    }

+    if (Boolean(this.props.showStepArrows)) {


No need for boolean call.

sbalaji1192 · 2022-12-13T11:20:26Z

app/client/src/widgets/InputWidgetV2/widget/index.tsx

+
+    if (
+      this.props.inputType === InputTypes.NUMBER &&
+      Boolean(this.props.showStepArrows)


No need for boolean call.

sbalaji1192 · 2022-12-13T11:25:49Z

...n/Smoke_TestSuite/ClientSideTests/Widgets/CurrencyInput/CurrencyInput_ShowStepArrows_spec.js

+    cy.get(widgetsPage.toggleShowStepArrows).click({ force: true });
+
+    // Add showStepArrows action and value as false
+    cy.testJsontext("showsteparrows", false);


I guess it should be cy.testJsontext("showsteparrows", {{false}});

sbalaji1192 · 2022-12-13T11:25:55Z

...n/Smoke_TestSuite/ClientSideTests/Widgets/CurrencyInput/CurrencyInput_ShowStepArrows_spec.js

+
+  it("4. Toggle test case to validate that currency input widget, stepArrows should be visible when toggle value is true", () => {
+    // Add showStepArrows action and value as true
+    cy.testJsontext("showsteparrows", true);


I guess it should be cy.testJsontext("showsteparrows", {{true}});

sbalaji1192 · 2022-12-13T11:26:24Z

...ess/integration/Smoke_TestSuite/ClientSideTests/Widgets/Input/Inputv2_ShowStepArrows_spec.js

+    cy.get(widgetsPage.toggleShowStepArrows).click({ force: true });
+
+    // Add showStepArrows action and value as false
+    cy.testJsontext("showsteparrows", false);


sbalaji1192 · 2022-12-13T11:26:29Z

...ess/integration/Smoke_TestSuite/ClientSideTests/Widgets/Input/Inputv2_ShowStepArrows_spec.js

+
+  it("4. Toggle test case to validate that dataType - NUMBER, stepArrows should be visible when toggle value is true", () => {
+    // Add showStepArrows action and add value as true
+    cy.testJsontext("showsteparrows", true);


…thub.com/appsmithorg/appsmith into APPSMTH-29

ghost · 2022-12-15T11:48:24Z

Apologies for delay in responding, we wanted to QA the code and avoid regression on our end.

sbalaji1192

The changes look good! Could you rebase the branch as there are some conflicts

laveena-en · 2022-12-20T06:25:40Z

Tested and verified this PR for step up/down arrows being optional for input widget (number) and currency input widget:

Migration
JS toggle for the property
Helper text
functionality in edit and deployed version
@dilippitchika This would require documentation changes

sbalaji1192 · 2022-12-20T06:27:09Z

/ok-to-test sha=d1477ef

github-actions · 2022-12-20T06:27:46Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3738088942.
Workflow: Appsmith External Integration Test Workflow.
Commit: d1477ef.
PR: 18764.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18764&runId=3738088942_1

dilippitchika · 2022-12-20T08:46:28Z

Thanks @laveena-en i will take a look at it

sbalaji1192 · 2022-12-21T06:19:54Z

/ok-to-test sha=3b3f709

github-actions · 2022-12-21T06:20:20Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3746941550.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3b3f709.
PR: 18764.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18764&runId=3746941550_1

github-actions · 2022-12-21T07:53:24Z

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/MaintainContext&Focus_spec.js

github-actions · 2022-12-21T12:18:22Z

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/MaintainContext&Focus_spec.js

Aishwarya-U-R · 2022-12-21T12:31:08Z

/ok-to-test sha=2de3c10

github-actions · 2022-12-21T12:31:34Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3749291777.
Workflow: Appsmith External Integration Test Workflow.
Commit: 2de3c10.
PR: 18764.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18764&runId=3749291777_1

github-actions · 2022-12-21T14:16:30Z

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/ButtonGroup_binding_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Scrolling_Spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitImport/ImportEmptyRepo_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Deploy_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/DisconnectGit_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/MaintainContext&Focus_spec.js

feat: make step up/down arrows in input Number and Currency widgets o…

ba038e3

…ptional

ghost self-assigned this Dec 7, 2022

ghost changed the title ~~[APPSMTH-29] [Feature]: make step up/down arrows in input Number and Currency widgets optional~~ feat: [APPSMTH-29] make step up/down arrows in input Number and Currency widgets optional Dec 7, 2022

vercel bot deployed to Preview – appsmith December 7, 2022 18:16 View deployment

ghost requested a review from sbalaji1192 December 7, 2022 18:19

ghost marked this pull request as ready for review December 7, 2022 18:19

sbalaji1192 reviewed Dec 8, 2022

View reviewed changes

gitstart-appsmith added 2 commits December 13, 2022 02:12

Merge commit '32d1de91088f0774cba0428534c3bf0c998bfb99' of https://gi…

5a87a31

…thub.com/appsmithorg/appsmith into APPSMTH-29

fix: added unit test for the migration and refactoring

9fb1007

ghost requested a review from sbalaji1192 December 13, 2022 02:13

vercel bot deployed to Preview December 13, 2022 02:27 View deployment

sbalaji1192 reviewed Dec 13, 2022

View reviewed changes

gitstart-appsmith added 2 commits December 15, 2022 11:47

Merge commit 'c72f8659623e82b3b689af66c2ee25dbddd7deef' of https://gi…

c8d3e42

…thub.com/appsmithorg/appsmith into APPSMTH-29

fix: review comments

a4f5ec8

ghost requested a review from sbalaji1192 December 15, 2022 11:48

vercel bot deployed to Preview December 15, 2022 12:04 View deployment

sbalaji1192 reviewed Dec 16, 2022

View reviewed changes

fix: Merge conflict

a5a9759

ghost requested a review from sbalaji1192 December 16, 2022 17:48

vercel bot deployed to Preview December 16, 2022 17:52 View deployment

fix: merge conflict

d1477ef

vercel bot deployed to Preview December 19, 2022 09:41 View deployment

sbalaji1192 approved these changes Dec 19, 2022

View reviewed changes

Merge branch 'release' into APPSMTH-29

3b3f709

vercel bot deployed to Preview December 21, 2022 06:26 View deployment

Merge branch 'release' into APPSMTH-29

2de3c10

vercel bot deployed to Preview December 21, 2022 12:40 View deployment

sbalaji1192 merged commit 585a194 into release Dec 21, 2022

sbalaji1192 deleted the APPSMTH-29 branch December 21, 2022 17:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [APPSMTH-29] make step up/down arrows in input Number and Currency widgets optional #18764

feat: [APPSMTH-29] make step up/down arrows in input Number and Currency widgets optional #18764

ghost commented Dec 7, 2022 •

edited by ghost

Loading

vercel bot commented Dec 7, 2022 •

edited

Loading

sbalaji1192 Dec 13, 2022

sbalaji1192 Dec 13, 2022

sbalaji1192 Dec 13, 2022

sbalaji1192 Dec 13, 2022

sbalaji1192 Dec 13, 2022

sbalaji1192 Dec 13, 2022

sbalaji1192 Dec 13, 2022

sbalaji1192 Dec 13, 2022

sbalaji1192 Dec 13, 2022

ghost commented Dec 15, 2022

sbalaji1192 left a comment

laveena-en commented Dec 20, 2022 •

edited

Loading

sbalaji1192 commented Dec 20, 2022

github-actions bot commented Dec 20, 2022

dilippitchika commented Dec 20, 2022

sbalaji1192 commented Dec 21, 2022

github-actions bot commented Dec 21, 2022

github-actions bot commented Dec 21, 2022

github-actions bot commented Dec 21, 2022

Aishwarya-U-R commented Dec 21, 2022

github-actions bot commented Dec 21, 2022

github-actions bot commented Dec 21, 2022

feat: [APPSMTH-29] make step up/down arrows in input Number and Currency widgets optional #18764

feat: [APPSMTH-29] make step up/down arrows in input Number and Currency widgets optional #18764

Conversation

ghost commented Dec 7, 2022 • edited by ghost Loading

Description

Type of change

How Has This Been Tested?

Checklist:

vercel bot commented Dec 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Dec 15, 2022

sbalaji1192 left a comment

Choose a reason for hiding this comment

laveena-en commented Dec 20, 2022 • edited Loading

sbalaji1192 commented Dec 20, 2022

github-actions bot commented Dec 20, 2022

dilippitchika commented Dec 20, 2022

sbalaji1192 commented Dec 21, 2022

github-actions bot commented Dec 21, 2022

github-actions bot commented Dec 21, 2022

github-actions bot commented Dec 21, 2022

Aishwarya-U-R commented Dec 21, 2022

github-actions bot commented Dec 21, 2022

github-actions bot commented Dec 21, 2022

ghost commented Dec 7, 2022 •

edited by ghost

Loading

vercel bot commented Dec 7, 2022 •

edited

Loading

laveena-en commented Dec 20, 2022 •

edited

Loading