-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Select Reskinning #16173
feat: Select Reskinning #16173
Conversation
Unable to find test scripts. Please add necessary tests to the PR. |
Unable to find test scripts. Please add necessary tests to the PR. |
@jsartisan For select widget:
|
app/client/src/widgets/MultiSelectTreeWidget/component/index.styled.tsx
Outdated
Show resolved
Hide resolved
@jsartisan Also, the error state is not being seen on the Tree-select widget when it is set to required. UPDATE: A separate issue has been raised for this #16264 |
/ok-to-test sha=9328f97 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2918908190. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2918908190. Click to view performance test results
|
@jsartisan Noticing some weird behaviour with select widget on release. |
Description
Current select widgets have many minor inconsistencies. This PR fixes them
Fixes #10988
Fixes #10991
Fixes #10984
Fixes #10990
Type of change
How Has This Been Tested?
Checklist: