Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invite user and password reset email not being sent via config page setup #14663

Merged
merged 4 commits into from
Jun 24, 2022
Merged

fix: invite user and password reset email not being sent via config page setup #14663

merged 4 commits into from
Jun 24, 2022

Conversation

ankitakinger
Copy link
Contributor

Description

Invite user and password reset emails not being sent via config page setup

Fixes #13976

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested if the values being passed to the API while toggling is correct.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ankitakinger ankitakinger self-assigned this Jun 19, 2022
@vercel
Copy link

vercel bot commented Jun 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ❌ Failed (Inspect) Jun 24, 2022 at 6:14AM (UTC)

@github-actions github-actions bot added Bug Something isn't working DevOps Pod Issues related to devops Email Config Issues related to configuring the email service High This issue blocks a user from building or impacts a lot of users Needs More Info Needs additional information labels Jun 19, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@ankitakinger ankitakinger added the Platform Administration Pod Issues related to platform administration & management label Jun 19, 2022
@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=81338c9

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2523988363.
Workflow: Appsmith External Integration Test Workflow.
Commit: 81338c9.
PR: 14663.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2523988363.
Commit: 81338c9.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 2008.85 811.44 1104.38 829.92 943.1 943.1 1139.54 43.86 39.23
painting 8.61 5.81 14.46 5.88 13.94 8.61 9.74 43.43 38.81
rendering 375.55 342.05 410.79 437.08 390.04 390.04 391.1 9.17 8.21
BIND_TABLE_DATA
scripting 2691.89 2374.85 2440.65 2518.6 2328.63 2440.65 2470.92 5.78 5.17
painting 20.01 22.93 38.35 49.73 18.47 22.93 29.9 45.55 40.74
rendering 879.39 920.71 1141.36 1077.44 1181.75 1077.44 1040.13 12.88 11.52
CLICK_ON_TABLE_ROW
scripting 2324.67 2841.24 3796.59 2743.93 3043.52 2841.24 2949.99 18.34 16.40
painting 178.58 37.7 39.93 34.16 34 37.7 64.87 98.06 87.71
rendering 384.43 601.38 1268.55 795.39 676.43 676.43 745.24 44.10 39.44
UPDATE_POST_TITLE
scripting 3815.8 4775.87 4028.89 4123.64 3019.58 4028.89 3952.76 16.01 14.32
painting 25.76 25.31 34.98 33.26 31.09 31.09 30.08 14.53 13.00
rendering 526.07 567.18 628.8 620.51 456.28 567.18 559.77 12.74 11.40
OPEN_MODAL
scripting 1416.06 1586.47 2035.04 1712.58 1574.01 1586.47 1664.83 13.95 12.47
painting 17.28 17.55 19.83 18.16 20.98 18.16 18.76 8.48 7.57
rendering 550.5 647.52 713.93 709.97 626.96 647.52 649.78 10.36 9.26
CLOSE_MODAL
scripting 700.66 978.38 1006.48 1057.32 915.69 978.38 931.71 14.91 13.34
painting 6.76 8.22 10.95 8.84 14.41 8.84 9.84 30.18 26.93
rendering 443.7 622.33 574.33 716.02 448.89 574.33 561.05 20.77 18.57
SELECT_WIDGET_MENU_OPEN
scripting 1592.02 1496.37 1656.27 1616.7 1582.72 1592.02 1588.82 3.71 3.32
painting 11.89 8.64 14.44 12.66 11.52 11.89 11.83 17.84 15.98
rendering 597.68 535.34 617.72 598.83 593.58 597.68 588.63 5.30 4.74
SELECT_WIDGET_SELECT_OPTION
scripting 257.66 263.9 248.64 298.65 252.3 257.66 264.23 7.60 6.80
painting 5.02 3.79 7.9 3.54 4.08 4.08 4.87 36.76 32.85
rendering 19.59 17.53 20.08 19 18.34 19 18.91 5.34 4.76

@IAmAnubhavSaini
Copy link
Contributor

@ankitakinger how does this affect #11703

I am trying to understand why it was introduced and now being removed. Could you provide some description on how this change helps with "Invite user and password reset emails not being sent via config page setup".

@vercel
Copy link

vercel bot commented Jun 23, 2022

Deployment failed with the following error:

Resource is limited - try again in 41 minutes (more than 100, code: "api-deployments-free-per-day").

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=b22705c

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2553332206.
Workflow: Appsmith External Integration Test Workflow.
Commit: b22705c.
PR: 14663.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2553332206.
Commit: b22705c.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 769.19 700.09 830.96 1975.79 721.14 769.19 999.43 54.84 49.05
painting 5.77 7.56 11.35 5.4 5.22 5.77 7.06 36.40 32.58
rendering 385.32 363.11 481.8 391.18 380.78 385.32 400.44 11.65 10.43
BIND_TABLE_DATA
scripting 2187.09 2224.36 2442.01 2153.41 2209.81 2209.81 2243.34 5.09 4.55
painting 21 19.08 16.35 25.16 16.89 19.08 19.7 18.12 16.19
rendering 1060.44 861.13 934.51 931.98 1000.35 934.51 957.68 7.90 7.07
CLICK_ON_TABLE_ROW
scripting 1909.05 4329.42 1940.43 1737.86 1873.71 1909.05 2358.09 46.85 41.90
painting 15.05 38.2 20.03 17.15 15.72 17.15 21.23 45.60 40.79
rendering 415.92 1228.11 373.29 372.47 380.52 380.52 554.06 68.08 60.90
UPDATE_POST_TITLE
scripting 3055.48 4096.67 3503.53 2799.86 3150.91 3150.91 3321.29 15.10 13.51
painting 19.71 27.51 30.1 36.16 18.63 27.51 26.42 27.78 24.83
rendering 520.9 671.74 654.2 482.02 526 526 570.97 15.05 13.46
OPEN_MODAL
scripting 1267.16 2519.86 1314 2789.94 1805.21 1805.21 1939.23 35.74 31.97
painting 11.52 29.75 13.19 14.25 17.85 14.25 17.31 42.35 37.90
rendering 551.03 663.32 572 578.45 729.39 578.45 618.84 12.15 10.87
CLOSE_MODAL
scripting 1190.81 693.48 679.76 1720.95 1865.3 1190.81 1230.06 45.21 40.43
painting 12.67 5.95 6.15 6.43 13.11 6.43 8.86 41.53 37.25
rendering 790.01 476.88 492.97 522.07 513.46 513.46 559.08 23.30 20.84
SELECT_WIDGET_MENU_OPEN
scripting 1553.3 1457.05 1431.63 1397.12 1469.44 1457.05 1461.71 3.98 3.56
painting 13.59 9.41 9.2 10.4 9.94 9.94 10.51 17.03 15.22
rendering 808.32 849.62 769.4 782.69 776.65 782.69 797.34 4.10 3.67
SELECT_WIDGET_SELECT_OPTION
scripting 217.31 239.73 284.36 230.78 236.42 236.42 241.72 10.48 9.37
painting 8.57 2.99 5.37 5.55 3.7 5.37 5.24 41.22 36.83
rendering 17.03 18.68 17.03 19.18 17.08 17.08 17.8 5.90 5.28

@ankitakinger
Copy link
Contributor Author

@ankitakinger how does this affect #11703

I am trying to understand why it was introduced and now being removed. Could you provide some description on how this change helps with "Invite user and password reset emails not being sent via config page setup".

This introduced a bug elsewhere. So this is a better fix right now to tackle both scenarios - the earlier one and the current one.

IAmAnubhavSaini
IAmAnubhavSaini suggested changes Jun 24, 2022
View reviewed changes
app/client/src/pages/Settings/FormGroup/Toggle.tsx Outdated Show resolved Hide resolved
app/client/src/pages/Settings/SettingsForm.tsx Outdated Show resolved Hide resolved
app/client/src/pages/Settings/SettingsForm.tsx Outdated Show resolved Hide resolved
app/client/src/pages/Settings/FormGroup/Toggle.tsx Show resolved Hide resolved
app/client/src/pages/Settings/FormGroup/Toggle.tsx Outdated Show resolved Hide resolved
app/client/src/pages/Settings/FormGroup/Toggle.tsx Outdated Show resolved Hide resolved
app/client/src/pages/Settings/FormGroup/Toggle.tsx Outdated Show resolved Hide resolved
app/client/src/pages/Settings/config/email.ts Show resolved Hide resolved
app/client/src/pages/Settings/SettingsForm.tsx Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Jun 24, 2022

Deployment failed with the following error:

Resource is limited - try again in 7 minutes (more than 100, code: "api-deployments-free-per-day").

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=ab806f7

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2553972521.
Workflow: Appsmith External Integration Test Workflow.
Commit: ab806f7.
PR: 14663.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2553972521.
Commit: ab806f7.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1159.84 806.53 927.86 670.99 700.66 806.53 853.18 23.31 20.85
painting 8.27 6.64 7.24 3.61 5.21 6.64 6.19 29.40 26.33
rendering 571.51 403.18 397.55 431.27 356.33 403.18 431.97 19.09 17.08
BIND_TABLE_DATA
scripting 2024.77 2087.62 2106.68 2110.37 2272.32 2106.68 2120.35 4.32 3.87
painting 22.95 28.38 19.81 16.98 19.1 19.81 21.44 20.66 18.47
rendering 1510.82 1163.26 894.63 910.99 864.64 910.99 1068.87 25.67 22.96
CLICK_ON_TABLE_ROW
scripting 3593.85 3511.98 1955.09 1562.6 1635.2 1955.09 2451.74 41.46 37.08
painting 26.4 36.24 13.59 15.33 23.24 23.24 22.96 39.81 35.63
rendering 976.52 1383.29 382.67 345.38 309.37 382.67 679.45 70.60 63.14
UPDATE_POST_TITLE
scripting 3782.52 3715.14 3157.4 4328.78 3569.53 3715.14 3710.67 11.38 10.18
painting 15.91 31.05 13.96 24.1 14.94 15.91 19.99 36.92 33.02
rendering 527.98 608.63 527.9 479.66 465.15 527.9 521.86 10.75 9.62
OPEN_MODAL
scripting 1741.81 1409.36 1422.56 1113.17 1553.84 1422.56 1448.15 15.89 14.21
painting 17.53 21.33 16.54 14.72 12.62 16.54 16.55 19.70 17.64
rendering 755.35 635.07 567.73 517.41 597.04 597.04 614.52 14.60 13.06
CLOSE_MODAL
scripting 979.59 2058.27 736.17 867.02 892.43 892.43 1106.7 48.71 43.57
painting 10.18 10.13 6.25 6.93 7.74 7.74 8.25 22.06 19.76
rendering 748.54 783.38 535.59 520.41 681.97 681.97 653.98 18.46 16.52
SELECT_WIDGET_MENU_OPEN
scripting 1368.15 1402.55 1340.75 1379.08 1372.17 1372.17 1372.54 1.62 1.45
painting 17.07 9.62 8.37 15.08 6.37 9.62 11.3 40.35 36.11
rendering 765.82 727 762.2 736.83 720.02 736.83 742.37 2.78 2.49
SELECT_WIDGET_SELECT_OPTION
scripting 229.39 202 210.25 213.08 213.25 213.08 213.59 4.65 4.16
painting 3.08 2.61 16.6 3.99 7.95 3.99 6.85 85.26 76.35
rendering 13.76 12.7 12.74 12.48 13.67 12.74 13.07 4.59 4.06

@ankitakinger ankitakinger merged commit 2452018 into release Jun 24, 2022
@ankitakinger ankitakinger deleted the fix/email-toggle branch June 24, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAmAnubhavSaini IAmAnubhavSaini IAmAnubhavSaini approved these changes

@albinAppsmith albinAppsmith Awaiting requested review from albinAppsmith

Assignees

@ankitakinger ankitakinger

Labels
Bug Something isn't working DevOps Pod Issues related to devops Email Config Issues related to configuring the email service High This issue blocks a user from building or impacts a lot of users Needs More Info Needs additional information Platform Administration Pod Issues related to platform administration & management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to send Forget Password and Invite mail even after configuaration of email service
2 participants
@ankitakinger @IAmAnubhavSaini