-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [server side change only] convert Mongo's form data to raw / native query #10058
Conversation
add comments add error handling
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/get-appsmith/appsmith/AkoFmMPAmYZ1Pg391WS1N1LV4NiK |
…o feature/mongo_form_to_native_4880
/ok-to-test sha=6f70e10 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1637243803. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey am I missing something here, where do we use the saved native format for execution?
Also, won't we need a UI designed for the conversion from form to native mode for this change? The way it works today, raw mode is an entirely separate command, and there is no way to switch an update form to raw at all. Let's talk about this a bit.
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
This PR has been closed because of inactivity. |
Re-opening it since it is under active development. This PR is currently blocked on #10109 |
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
This PR has been closed because of inactivity. |
…o feature/mongo_form_to_native_4880
remove setting formData.body
/ok-to-test sha=55f48cf |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2075844872. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2075844872. Click to view performance test results
|
Description
formData.misc.formToNativeQuery.status
: success / errorformData.misc.formToNativeQuery.data
: translated raw query if status is success or error message if status is error.Fixes #4880
Type of change
How Has This Been Tested?
Checklist: