[Task]: Remove extra space after icon in entity item and Data tab isn't showing the warning icon when no datasources are connected #37675
Assignees
Labels
IDE Pod
Issues that new developers face while exploring the IDE
IDE Product
Issues related to the IDE Product
Task
A simple Todo
Comments
ankitakinger
added
IDE Product
Merged
2 tasks
ankitakinger
added a commit
that referenced
this issue
Nov 25, 2024
… button condition prop (#37674) ## Description - Removing unused styles and extra space between icon and entity name in entity item component - Passing button condition prop that is missing to show the warning icon on Data tab in sidebar, when there are no datasources connected in the workspace Fixes [#37675](#37675) ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12009273207> > Commit: f4bc4ab > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12009273207&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Mon, 25 Nov 2024 12:15:09 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a `condition` property for enhanced button configuration in the sidebar. - Added an optional `preRightIcon` property to the `Entity` component for improved icon customization. - **Bug Fixes** - Simplified styling of the `IconWrapper`, potentially improving icon display. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions bot
pushed a commit
to Zeral-Zhang/appsmith
that referenced
this issue
Nov 27, 2024
… button condition prop (appsmithorg#37674) ## Description - Removing unused styles and extra space between icon and entity name in entity item component - Passing button condition prop that is missing to show the warning icon on Data tab in sidebar, when there are no datasources connected in the workspace Fixes [appsmithorg#37675](appsmithorg#37675) ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12009273207> > Commit: f4bc4ab > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12009273207&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Mon, 25 Nov 2024 12:15:09 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a `condition` property for enhanced button configuration in the sidebar. - Added an optional `preRightIcon` property to the `Entity` component for improved icon customization. - **Bug Fixes** - Simplified styling of the `IconWrapper`, potentially improving icon display. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SubTasks
The text was updated successfully, but these errors were encountered: