Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Duplicate page name error does not disappear on navigating to other pages #35949

Closed
1 task done
shadabbuchh opened this issue Aug 28, 2024 · 3 comments · Fixed by #36320
Closed
1 task done

[Bug]: Duplicate page name error does not disappear on navigating to other pages #35949

shadabbuchh opened this issue Aug 28, 2024 · 3 comments · Fixed by #36320
Assignees
@rohan-arthur
Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Inviting Contribution Issues that we would like contributions to Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Page Management Issues related to configuring pages Production UX Improvement

Comments

@shadabbuchh
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Error on setting duplicate page name does not disappear when we got to some other page's settings.

Steps To Reproduce

  1. Create an application & add 3 pages (Page1, Page2, Page3).
  2. Go to Page2 settings & rename it to Page1. This will throw an error as expected.
  3. Now go to Page3 settings.

Expected: The error should disappear when navigating to a different page's settings.

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

https://jam.dev/c/e28bed4e-c5a4-4e2c-8326-ebccec882ea6

Version

Cloud
@shadabbuchh shadabbuchh added Bug Something isn't working UX Improvement Page Management Issues related to configuring pages Production Needs Triaging Needs attention from maintainers to triage Medium Issues that frustrate users due to poor UX labels Aug 28, 2024
@github-actions github-actions bot added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE labels Aug 28, 2024
@rohan-arthur rohan-arthur added the Inviting Contribution Issues that we would like contributions to label Aug 29, 2024
@raushan3737
Copy link
Contributor

Hi @shadabbuchh , @rohan-arthur, I would like to work on this Issue. Can i pick this issue?

@rohan-arthur
Copy link
Contributor

@raushan3737 please go ahead and thank you!

@Shivam-z
Copy link
Contributor

Shivam-z commented Sep 5, 2024 •
edited
Loading

Hi @rohan-arthur, @raushan3737 has transitioned to another task, so I will be taking over this ticket now.

@Shivam-z Shivam-z mentioned this issue Sep 12, 2024
Closed
2 tasks
@a6hishekpandey a6hishekpandey mentioned this issue Sep 14, 2024
Merged
2 tasks
This was referenced Sep 17, 2024
Closed
Closed
KelvinOm pushed a commit that referenced this issue Sep 19, 2024
@a6hishekpandey
fix: duplicate page name error does not disappear on navigating to ot…
66270b4 
…her pages (#36320)

## Description 
**Issue:** Duplicate page name error does not disappear on navigating to
other pages.

This PR addresses issue #35949 by resetting the isPageNameValid state to
undefined using useEffect hook when the Page settings loads.

Fixes #35949 

> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved page name validation by resetting its state when the page
data updates, ensuring accurate checks based on new information.
- **Style**
	- Minor formatting adjustment for better code readability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
@a6hishekpandey @Shivam-z
fix: duplicate page name error does not disappear on navigating to ot…
df63890 
…her pages (appsmithorg#36320)

## Description 
**Issue:** Duplicate page name error does not disappear on navigating to
other pages.

This PR addresses issue appsmithorg#35949 by resetting the isPageNameValid state to
undefined using useEffect hook when the Page settings loads.

Fixes appsmithorg#35949 

> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved page name validation by resetting its state when the page
data updates, ensuring accurate checks based on new information.
- **Style**
	- Minor formatting adjustment for better code readability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohan-arthur rohan-arthur

Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Inviting Contribution Issues that we would like contributions to Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Page Management Issues related to configuring pages Production UX Improvement
Projects
None yet
Milestone
No milestone
4 participants
@shadabbuchh @rohan-arthur @raushan3737 @Shivam-z