[Task]: Add search functionality for workflows #30843
Assignees
Labels
Task
A simple Todo
Workflows Pod
Issues that the workflows team owns
Workflows Product
Issues related to the workflows product
Comments
deepikaappsmith
added
Task
16 tasks
srix
pushed a commit
that referenced
this issue
Feb 28, 2024
## Description > Code split for entity search. > 1. Move the methods to SearchEntityHelper to be readily available for re-use. > 2. Rename SearchEntitySolutionTest -> SearchEntitySolutionCETest #### PR fixes following issue(s) Fixes [[Task]: Add search functionality for workflows #30843](#30843) #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? > None, as this is just a refactor. #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved code efficiency in search functionality by centralizing the logic for creating pageable and sort objects. - **Tests** - Renamed a test class to better reflect its purpose. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
Nikhil-Nandagopal
added
the
Workflows Product
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SubTasks
With the updated homepege experience we have introduced a search API in this #29203. This ticket expects to extend the search functionality for the workflows.
The text was updated successfully, but these errors were encountered: