Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: API for search functionality for updated homepage experience #28793

Closed
abhvsn opened this issue Nov 10, 2023 · 0 comments · Fixed by #29203
Closed

[Feature]: API for search functionality for updated homepage experience #28793

abhvsn opened this issue Nov 10, 2023 · 0 comments · Fixed by #29203
Assignees
@abhvsn
Labels
Backend This marks the issue or pull request to reference server code Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers

Comments

@abhvsn
Copy link
Contributor

abhvsn commented Nov 10, 2023 •
edited
Loading

Ref: https://www.notion.so/appsmith/Task-estimation-for-Homepage-experience-581af64ce0c94c8c975ad64f86ee17f7
@abhvsn abhvsn added Backend This marks the issue or pull request to reference server code Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers Homepage Experience V2 labels Nov 10, 2023
@abhvsn abhvsn self-assigned this Nov 10, 2023
@github-actions github-actions bot removed the Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers label Nov 10, 2023
@abhvsn abhvsn added the Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers label Nov 10, 2023
@github-actions github-actions bot removed the Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers label Nov 10, 2023
@deepikaappsmith deepikaappsmith added the Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers label Nov 10, 2023
@abhvsn abhvsn mentioned this issue Dec 5, 2023
Merged
20 tasks
Aishwarya-U-R pushed a commit that referenced this issue Dec 8, 2023
@abhvsn
feat: API for search entities (#29203)
441795c 
### Description
As per updated homepage experience search functionality will be handled
by server and will be applicable for all the entities present on
homepage.

Request format:
```
curl --location 'https://dev.appsmith.com/api/v1/search-entities?keyword=test&page=0&size=10&entities={comma separated entity names e.g.Application,Workspace}' \
--header 'Cookie: SESSION={logged_in_user's_session_cookie}'
```

Note: We will be running a couple of experiment to optimise the search,
with this PR we have implemented basic search with contains
functionality and index is applied on the searchable fields. Mongo does
offer [text-search
functionality](https://www.mongodb.com/docs/manual/text-search/) based
on tokenisation which may tackle the incorrect spellings scenario. But
as the searches are for names we have avoided that route for now as
language tokenisation was not providing the expected results which basic
search was able to.

Design handoff:

https://app.zeplin.io/project/653f7de4c1d563203f817bce/screen/653f7eea5d02e7233ede382c
<img width="1095" alt="Screenshot 2023-12-07 at 3 09 02 AM"
src="https://github.com/appsmithorg/appsmith/assets/41686026/c26225ef-9d78-4969-b445-a78bc58c18a0">

#### PR fixes following issue(s)
Fixes #28793


#### Type of change
- New feature (non-breaking change which adds functionality)

## Testing
>
#### How Has This Been Tested?
- [x] Manual
- [x] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new search functionality that allows users to find and
sort applications and workspaces.
- Added the ability to view recently used applications in a sorted
order.

- **Improvements**
- Enhanced the application sorting mechanism to prioritize recently used
items.
- Streamlined the process of checking if an application is connected to
Git.

- **Bug Fixes**
- Fixed an issue where the list of applications was not updating
correctly for recently used items.

- **Deprecated Features**
  - Marked the `getAllApplicationsForHome` method as deprecated.

- **Tests**
- Added new test cases to ensure the reliability of the search and
sorting features.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhvsn abhvsn

Labels
Backend This marks the issue or pull request to reference server code Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: API for search entities appsmithorg/appsmith
2 participants
@abhvsn @deepikaappsmith