[Bug]: Create new API payload effects Git discard functionality #28237
Assignees
Labels
Bug
Something isn't working
Deploy Preview
Issues found in Deploy Preview
Integrations Pod General
Issues related to the Integrations Pod that don't fit into other tags.
Integrations Product
Issues related to a specific integration
Needs Triaging
Needs attention from maintainers to triage
QA
Needs QA attention
Query & JS Pod
Issues related to the query & JS Pod
UI Building Product
Issues related to the UI Building experience
Comments
riodeuno
added
Bug
github-actions
bot
added
the
UI Building Product
20 tasks
NilanshBansal
added
the
Integrations Pod General
github-actions
bot
added
Integrations Product
18 tasks
riodeuno
added a commit
that referenced
this issue
Oct 24, 2023
## Description - Add the `applicationDetail` payload to the create application request. - This allows instances which have Anvil enabled, to default to Anvil when an application is created. #### PR fixes following issue(s) Fixes #28237 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress - If all existing tests pass, we're good to merge ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --------- Co-authored-by: nilansh <nilansh@appsmith.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Description
applicationDetail: { appPositioning: { type: "FIXED" } }to the create application API payload, the issue [Bug]: Not able to discard app settings changes for the first time in git connected app #24920 resurfaces.Steps To Reproduce
Public Sample App
No response
Environment
Deploy Preview
Issue video log
No response
Version
1.9.41
The text was updated successfully, but these errors were encountered: