Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Remove the warning message for environments shown during deployments #27485

Closed
1 task done
sribalajig opened this issue Sep 20, 2023 · 0 comments · Fixed by #28335
Closed
1 task done

[Enhancement]: Remove the warning message for environments shown during deployments #27485

sribalajig opened this issue Sep 20, 2023 · 0 comments · Fixed by #28335
Assignees
@ayushpahwa
Labels
Artifact Platform Product Issues related to the application platform Data Platform Pod Issues related to the underlying data platform Enhancement New feature or request Environments Product Issues related to datasource environments Git Platform Issues related to the git & the app platform Publish App Issues related to app deployment QA Needs QA attention Query & JS Pod Issues related to the query & JS Pod

Comments

@sribalajig
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Summary

When a user is deploying their app, we show them the following warning message :
Screenshot 2023-09-20 at 7 28 05 AM
This message was introduced for the following reason -

When a user is on staging in edit mode, and they click on deploy, they may assume that the app is going to be deployed in the "staging instance". But Appsmith does not support separate instances for staging and production. We always deploy in a single instance, with production configurations. This warning is conveying that information.

This message is raising more questions than it answers. So we're going to remove it for now and see if it is an actual problem or not.

Why should this be worked on?

This is a fabricated problem especially not needed for new users. A new user will deploy several times before the app actually reaches their user for the first time so there is no danger of this confusion. For the limited set of business edition users we currently have, this is not going to be a big confusion.
@sribalajig sribalajig added Enhancement New feature or request Environments Product Issues related to datasource environments Publish App Issues related to app deployment Multiple Environments labels Sep 20, 2023
@github-actions github-actions bot added Data Platform Pod Issues related to the underlying data platform Query & JS Pod Issues related to the query & JS Pod labels Sep 20, 2023
@github-project-automation github-project-automation bot moved this to Needs Triaging in Data Platform Pod Sep 20, 2023
@sribalajig sribalajig mentioned this issue Sep 20, 2023
Closed
1 task
@sribalajig sribalajig moved this from Needs Triaging to 📋 Backlog in Data Platform Pod Sep 20, 2023
@riteshkew riteshkew moved this from 📋 Backlog to 🔖 Sprint Backlog in Data Platform Pod Oct 17, 2023
@riteshkew riteshkew assigned ayushpahwa and unassigned riteshkew Oct 20, 2023
@ayushpahwa ayushpahwa mentioned this issue Oct 24, 2023
Merged
20 tasks
@ayushpahwa ayushpahwa moved this from 🔖 Sprint Backlog to 👀 Needs QA in Data Platform Pod Oct 24, 2023
Aishwarya-U-R pushed a commit that referenced this issue Oct 25, 2023
@ayushpahwa
fix: remove deploy messages for environments (#28335)
d80fa0a 
## Description
PR to remove deploy warnings and messages for environments feature from
the deploy flow

#### PR fixes following issue(s)
Fixes #27485 

#### Type of change

- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
@github-project-automation github-project-automation bot moved this from 👀 Needs QA to Closed in Data Platform Pod Oct 25, 2023
@appsmith-bot appsmith-bot added the QA Needs QA attention label Oct 25, 2023
@Nikhil-Nandagopal Nikhil-Nandagopal added the Artifact Platform Product Issues related to the application platform label Aug 5, 2024
@github-actions github-actions bot added the Git Platform Issues related to the git & the app platform label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayushpahwa ayushpahwa

Labels
Artifact Platform Product Issues related to the application platform Data Platform Pod Issues related to the underlying data platform Enhancement New feature or request Environments Product Issues related to datasource environments Git Platform Issues related to the git & the app platform Publish App Issues related to app deployment QA Needs QA attention Query & JS Pod Issues related to the query & JS Pod
Projects
Data Platform Pod
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove deploy messages for environments appsmithorg/appsmith
5 participants
@Nikhil-Nandagopal @ayushpahwa @sribalajig @riteshkew @appsmith-bot