Skip to content

Commit

Permalink
fix: Minor issues
Browse files Browse the repository at this point in the history
  • Loading branch information
hetunandu committed Dec 26, 2024
1 parent 3c802d9 commit 92a1b59
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ const CommonEditorForm = (props: Props) => {
const paramsCount = getParamsCount(actionParams, datasourceHeaders);

return (
<Styled.Tabs onValueChange={setCurrentTab} value={currentTab}>
<Styled.Tabs
data-testid={props.dataTestId}
onValueChange={setCurrentTab}
value={currentTab}
>
<Styled.FormHeader>
<InfoFields
actionName={action.name}
Expand Down
1 change: 1 addition & 0 deletions app/client/src/ce/constants/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2307,6 +2307,7 @@ export const DATA_PANE_TITLE = () => "Datasources in your workspace";
export const DATASOURCE_LIST_BLANK_DESCRIPTION = () =>
"Connect a datasource to write your first query";
export const DATASOURCE_BLANK_STATE_MESSAGE = () => "No datasources to display";
export const DATASOURCE_BLANK_STATE_CTA = () => "Bring your data";

// Create New Apps Intermediary step
export const CREATE_NEW_APPS_STEP_TITLE = () => "How would you like to start?";
Expand Down
5 changes: 3 additions & 2 deletions app/client/src/pages/Editor/IDE/LeftPane/DataSidePane.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ import { useLocation } from "react-router";
import {
createMessage,
DATA_PANE_TITLE,
DATASOURCE_BLANK_STATE_CTA,
DATASOURCE_LIST_BLANK_DESCRIPTION,
} from "ee/constants/messages";
import PaneHeader from "./PaneHeader";
import { useEditorType } from "ee/hooks";
import { INTEGRATION_TABS } from "../../../../constants/routes";
import { INTEGRATION_TABS } from "constants/routes";
import type { AppState } from "ee/reducers";
import { getCurrentAppWorkspace } from "ee/selectors/selectedWorkspaceSelectors";
import { useFeatureFlag } from "utils/hooks/useFeatureFlag";
Expand Down Expand Up @@ -99,7 +100,7 @@ const DataSidePane = (props: DataSidePaneProps) => {
() => ({
className: "t--add-datasource-button-blank-screen",
testId: "t--add-datasource-button-blank-screen",
text: createMessage(DATA_PANE_TITLE),
text: createMessage(DATASOURCE_BLANK_STATE_CTA),
onClick: canCreateDatasource ? addButtonClickHandler : undefined,
}),
[addButtonClickHandler, canCreateDatasource],
Expand Down

0 comments on commit 92a1b59

Please sign in to comment.