Add first backtrace line to error causes #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To give a bit more context about the error causes, include the first backtrace line, showing where it originates. The server needs to be updated to show this in the UI. Part of appsignal/feature-requests#387
If the Rails backtrace cleaner filter is present also run the error cause backtrace through the filter as well. Replicate our processor behavior for the error causes by stripping of the app/root path in the Ruby gem.
unflxw
approved these changes
Sep 25, 2024
luismiramirez
approved these changes
Sep 26, 2024
This is a message from the daily scheduled checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add first backtrace line to error causes
To give a bit more context about the error causes, include the first backtrace line, showing where it originates.
The server needs to be updated to show this in the UI.
Part of https://github.com/appsignal/feature-requests/issues/387
Run error cause backtrace lines through filters
If the Rails backtrace cleaner filter is present also run the error cause backtrace through the filter as well.
Replicate our processor behavior for the error causes by stripping of the app/root path in the Ruby gem.