Format Date and Time objects stored in sample data #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombruijn
force-pushed
the
format-date-and-time
branch
3 times, most recently
from
2e01b2d
to
ceb2f0e
Compare
Format the Date and Time objects in a human-friendly way. Previously, dates and times stored in sample data, like session data, would be shown as `#<Date>` and `#<Time>`. They will now be show as `#<Date: 2024-09-11>` and `#<Time: Time: 2024-09-12T13:14:15+02:00>`. (The time zone will be based on the setting in Ruby.) The UTC offset is included in the Time object on purpose. Casting it to UTC will lose the timezone information.
tombruijn
force-pushed
the
format-date-and-time
branch
from
ceb2f0e
to
e266d3a
Compare
unflxw
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format the Date and Time objects in a human-friendly way. Previously, dates and times stored in sample data, like session data, would be shown as
#<Date>and#<Time>.They will now be show as
#<Date: 2024-09-11>and#<Time: Time: 2024-09-12T13:14:15+02:00>.(The time zone will be based on the setting in Ruby.)
The UTC offset is included in the Time object on purpose. Casting it to UTC will lose the timezone information.