Update benchmark task #1173
Merged
Update benchmark task #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benchmark task should load the project's Ruby gem, not whatever version is installed on the system. Add the project path to the LOAD_PATH so it uses the local project.
Don't exclude it, but include it in the files checked by RuboCop. Fix the issues that were reported. [skip changeset]
The benchmark is not complete without setting the minimal required transaction data. Without this all samples are discarded in this benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load local Ruby gem in benchmark task
The benchmark task should load the project's Ruby gem, not whatever version is installed on the system.
Add the project path to the LOAD_PATH so it uses the local project.
Include benchmark Rake task in RuboCop rules
Don't exclude it, but include it in the files checked by RuboCop. Fix the issues that were reported.
[skip changeset]
Set transaction action name in benchmark script
The benchmark is not complete without setting the minimal required transaction data. Without this all samples are discarded in this benchmark.
[skip review]