-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental Web Vitals support for Next.js #148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamyeats
force-pushed
the
nextjs-web-vitals
branch
from
May 14, 2020 18:05
80ba56e
to
c672d53
Compare
See appsignal/public_config#18 for magic dashboard config. |
adamyeats
changed the title
Add experimental Web Vitals support
Add experimental Web Vitals support for Next.js
May 14, 2020
Closed
adamyeats
force-pushed
the
nextjs-web-vitals
branch
5 times, most recently
from
May 14, 2020 22:32
6a2b5c1
to
a577c22
Compare
This comment has been minimized.
This comment has been minimized.
adamyeats
force-pushed
the
nextjs-web-vitals
branch
from
May 19, 2020 11:12
a577c22
to
f702781
Compare
This comment has been minimized.
This comment has been minimized.
jeffkreeftmeijer
approved these changes
May 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
While performing the daily checks some issues were found with this Pull Request. |
thijsc
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds experimental support for Next.js v9.4 Web Vitals reporting. This works by providing an Express middleware which will mount a route to
/__appsignal-web-vitals
andPOST
the metrics to that, and we’ll add custom metrics for these metrics on the server.This works by exporting a
reportWebVitals
function frompages/_app.js
as described here.On successful setup, two new magic dashboards will be created for the user - Next.js and Next.js Web Vitals.