Rename heartbeats to cron check-ins #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unflxw
force-pushed
the
rename-heartbeats-to-cron-checkins
branch
2 times, most recently
from
a0d8976
to
e089dc2
Compare
unflxw
added a commit
to appsignal/appsignal-python
that referenced
this pull request
Jul 12, 2024
unflxw
force-pushed
the
rename-heartbeats-to-cron-checkins
branch
from
e089dc2
to
d1af160
Compare
unflxw
added a commit
to appsignal/appsignal-python
that referenced
this pull request
Jul 12, 2024
See also appsignal/appsignal-nodejs#1079. In Ruby and Node.js, we use `const_missing` and `Proxy` respectively to make `Heartbeat` pretend to be `Cron`, allowing the result of instantiating one to pass an instance class check for the other and vice-versa, while also emitting a deprecation warning in the process. Since the above is not possible in Python, we instead make a `Heartbeat` class that emits the deprecation warning, returns instances of `Cron` when initialised, and also pretends to be `Cron` when instance-checked against. It's not perfect (neither is `Proxy`) but it does the trick.
unflxw
added a commit
to appsignal/appsignal-python
that referenced
this pull request
Jul 15, 2024
See also appsignal/appsignal-nodejs#1079. In Ruby and Node.js, we use `const_missing` and `Proxy` respectively to make `Heartbeat` pretend to be `Cron`, allowing the result of instantiating one to pass an instance class check for the other and vice-versa, while also emitting a deprecation warning in the process. Since the above is not possible in Python, we instead make a `Heartbeat` class that emits the deprecation warning, returns instances of `Cron` when initialised, and also pretends to be `Cron` when instance-checked against. It's not perfect (neither is `Proxy`) but it does the trick.
unflxw
added a commit
to appsignal/appsignal-python
that referenced
this pull request
Jul 15, 2024
See also appsignal/appsignal-nodejs#1079. In Ruby and Node.js, we use `const_missing` and `Proxy` respectively to make `Heartbeat` pretend to be `Cron`, allowing the result of instantiating one to pass an instance class check for the other and vice-versa, while also emitting a deprecation warning in the process. Since the above is not possible in Python, we instead make a `Heartbeat` class that emits the deprecation warning, returns instances of `Cron` when initialised, and also pretends to be `Cron` when instance-checked against. It's not perfect (neither is `Proxy`) but it does the trick.
unflxw
added a commit
to appsignal/appsignal-python
that referenced
this pull request
Jul 15, 2024
See also appsignal/appsignal-nodejs#1079. In Ruby and Node.js, we use `const_missing` and `Proxy` respectively to make `Heartbeat` pretend to be `Cron`, allowing the result of instantiating one to pass an instance class check for the other and vice-versa, while also emitting a deprecation warning in the process. Since the above is not possible in Python, we instead make a `Heartbeat` class that emits the deprecation warning, returns instances of `Cron` when initialised, and also pretends to be `Cron` when instance-checked against. It's not perfect (neither is `Proxy`) but it does the trick.
unflxw
added a commit
to appsignal/appsignal-python
that referenced
this pull request
Jul 15, 2024
See also appsignal/appsignal-nodejs#1079. In Ruby and Node.js, we use `const_missing` and `Proxy` respectively to make `Heartbeat` pretend to be `Cron`, allowing the result of instantiating one to pass an instance class check for the other and vice-versa, while also emitting a deprecation warning in the process. Since the above is not possible in Python, we instead make a `Heartbeat` class that emits the deprecation warning, returns instances of `Cron` when initialised, and also pretends to be `Cron` when instance-checked against. It's not perfect (neither is `Proxy`) but it does the trick.
unflxw
force-pushed
the
rename-heartbeats-to-cron-checkins
branch
from
d1af160
to
8b057f1
Compare
This comment has been minimized.
This comment has been minimized.
unflxw
force-pushed
the
rename-heartbeats-to-cron-checkins
branch
2 times, most recently
from
a847885
to
e477ecd
Compare
luismiramirez
approved these changes
Aug 6, 2024
unflxw
added a commit
to appsignal/appsignal-python
that referenced
this pull request
Aug 7, 2024
See also appsignal/appsignal-nodejs#1079. In Ruby and Node.js, we use `const_missing` and `Proxy` respectively to make `Heartbeat` pretend to be `Cron`, allowing the result of instantiating one to pass an instance class check for the other and vice-versa, while also emitting a deprecation warning in the process. Since the above is not possible in Python, we instead make a `Heartbeat` class that emits the deprecation warning, returns instances of `Cron` when initialised, and also pretends to be `Cron` when instance-checked against. It's not perfect (neither is `Proxy`) but it does the trick.
See appsignal/appsignal-elixir#957. Emit a deprecation warning both when the `heartbeat` helper is used and when the `Heartbeat` class is initialised, but only once each.
Change the endpoint to `/check_ins/json` and amend the event format to use `identifier` instead of `name`, `digest` instead of `id`, and a new `check_in_type` field.
unflxw
force-pushed
the
rename-heartbeats-to-cron-checkins
branch
from
e477ecd
to
1f6984b
Compare
tombruijn
approved these changes
Aug 7, 2024
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Use `identifier` and `digest` instead of `name` and `id` respectively.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This is a message from the daily scheduled checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See appsignal/appsignal-elixir#957.
Emit a deprecation warning both when the
heartbeathelper is used and when theHeartbeatclass is initialised, but only once each.