Prevent install from running in test env #992
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Elixir 1.18, `mix test` will attempt to re-run the installation Mix task again. As it's running in test mode, the modules it depends on will have been stubbed out by our test config. But the processes for those modules have not been started yet, so the task crashes. Guard against this when the task starts and bail out if in test env. WARNING: This is a draft to work around the issue. I have no idea what unintended effects this has -- can the tests for the helper task even run now? Do not merge this without further testing.
|
✔️ All good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Elixir 1.18,
mix testwill attempt to re-run the installation Mix task again. As it's running in test mode, the modules it depends on will have been stubbed out by our test config. But the processes for those modules have not been started yet, so the task crashes.Guard against this when the task starts and bail out if in test env.
WARNING: This is a draft to work around the issue. I have no idea what unintended effects this has -- can the tests for the helper task even run now? Do not merge this without further testing.