Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appsignal.Transaction.set_error/4 handles unformatted stacktraces #72

Merged
merged 2 commits into from
Jan 13, 2017

Conversation

jeffkreeftmeijer
Copy link
Member

We assume that a list with a tuple as its first element is an unformatted stack trace. In that case we'll call Appsignal.ErrorHandler.format_stack/1 on it in Appsignal.Transaction.set_error/4, so modules that call it don't need coupling with Appsignal.ErrorHandler.

@arjan arjan merged commit bca9991 into master Jan 13, 2017
@tombruijn tombruijn deleted the format_stack branch February 3, 2017 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants