Fix bin/setup script, exit on failure #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `set -eu` options so that the setup script exits with a failure if any of the commands it runs exits with a failure as well. Otherwise it will silently fail and go unnoticed.
tombruijn
force-pushed
the
fix-setup-script
branch
from
e6c015a to
7eacb3b
Compare
jeffkreeftmeijer
pushed a commit
that referenced
this pull request
Oct 18, 2021
Add the `set -e` options so that the setup script exits with a failure if any of the commands it runs exits with a failure as well. Otherwise it will silently fail and go unnoticed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
set -eoptions so that the setup script exits with a failureif any of the commands it runs exits with a failure as well. Otherwise
it will silently fail and go unnoticed.
[skip changeset]
[skip review]