Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 'test_no_nif' test environment which skips the NIF #101

Merged
merged 3 commits into from
Jan 27, 2017
Merged

Implement 'test_no_nif' test environment which skips the NIF #101

merged 3 commits into from
Jan 27, 2017

Conversation

arjan
Copy link
Contributor

@arjan arjan commented Jan 26, 2017 •
edited by tombruijn
Loading

Closes #96

tombruijn
tombruijn reviewed Jan 26, 2017
View reviewed changes
test/appsignal/nif_test.exs
@@ -14,7 +14,16 @@ defmodule Appsignal.NifTest do
assert is_binary(transaction)
end

test "the nif is loaded" do
assert true = Appsignal.Nif.loaded?
if Mix.env in [:test, :test_phoenix] do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't if Mix.env != :test_no_nif do be more flexible if we add more test suites than test and test_phoenix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right :)

@arjan arjan merged commit c4b2a88 into develop Jan 27, 2017
@tombruijn tombruijn deleted the test-nif-not-loaded-96 branch January 27, 2017 14:30
jeffkreeftmeijer pushed a commit that referenced this pull request Jan 27, 2017
@jeffkreeftmeijer
Implement 'test_no_nif' test environment which skips the NIF (#101)
0605918 
* Implement 'test_no_nif' test environment which skips the NIF

* Fix test for Nif.loaded? when the NIF is not loaded

* Revert the NIF environment test
jeffkreeftmeijer pushed a commit that referenced this pull request Jan 31, 2017
@jeffkreeftmeijer
Implement 'test_no_nif' test environment which skips the NIF (#101)
4597ecf 
* Implement 'test_no_nif' test environment which skips the NIF

* Fix test for Nif.loaded? when the NIF is not loaded

* Revert the NIF environment test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombruijn tombruijn tombruijn approved these changes

@jeffkreeftmeijer jeffkreeftmeijer Awaiting requested review from jeffkreeftmeijer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arjan @tombruijn