Skip to content

Commit

Permalink
Update default request_headers list
Browse files Browse the repository at this point in the history
`request_headers` list had some elements inherited from the Ruby
integration that were exclusive to `Rack`. The list is now updated and
only includes headers that make sense.
  • Loading branch information
luismiramirez committed Dec 15, 2021
1 parent c4be06d commit ffe6521
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
bump: "patch"
type: "change"
---

Remove Ruby exclusive headers from request_headers defaults.
3 changes: 1 addition & 2 deletions lib/appsignal/config.ex
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ defmodule Appsignal.Config do
log: "file",
request_headers: ~w(
accept accept-charset accept-encoding accept-language cache-control
connection content-length path-info range request-method request-uri
server-name server-port server-protocol
connection content-length range
),
send_environment_metadata: true,
send_params: true,
Expand Down
3 changes: 1 addition & 2 deletions test/appsignal/config_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -1006,8 +1006,7 @@ defmodule Appsignal.ConfigTest do
log: "file",
request_headers: ~w(
accept accept-charset accept-encoding accept-language cache-control
connection content-length path-info range request-method request-uri
server-name server-port server-protocol
connection content-length range
),
send_environment_metadata: true,
send_params: true,
Expand Down
2 changes: 1 addition & 1 deletion test/integration/diagnose
Submodule diagnose updated 1 files
+3 −15 spec/diagnose_spec.rb

0 comments on commit ffe6521

Please sign in to comment.