Record request information as metadata #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aside from just adding request information to the environment field, add it to the metadata as well to allow for use in filtering. Fixes appsignal/support#333.
jeffkreeftmeijer
force-pushed
the
metadata
branch
from
8c13f73 to
49a2f25
Compare
tombruijn
requested changes
Aug 30, 2024
There was a problem hiding this comment.
This will work, but it can't be amended by something else, like if we want to add more metadata from the Plug or Absinthe integration too.
I suggested using the set_meta_data Nif function but I noticed that doesn't work for the Span API or the attribute functions, but we can do that later if needed. It will show in the same place.
unflxw
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Looks good modulo @tombruijn's comments. On what Tom said, re: making it possible to override it, it might help if it was possible to set this data when the span is created, rather than when it is closed.
Co-authored-by: Tom de Bruijn <tom@tomdebruijn.com>
Co-authored-by: Tom de Bruijn <tom@tomdebruijn.com>
Co-authored-by: Tom de Bruijn <tom@tomdebruijn.com>
Co-authored-by: Tom de Bruijn <tom@tomdebruijn.com>
Recent changes prefixed the metadata names with "request" or "response", and removed the hostname field. This patch updates the test to reflect those changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from just adding request information to the environment field, add it to the metadata as well to allow for use in filtering.
Fixes https://github.com/appsignal/support/issues/333.