Fix code that doesn't work on Ginkgo (Django 1.8)#261
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 92.03% 91.87% -0.16%
==========================================
Files 41 41
Lines 2134 2142 +8
==========================================
+ Hits 1964 1968 +4
- Misses 170 174 +4
Continue to review full report at Codecov.
|
OmarIthawi
approved these changes
Sep 28, 2020
| modified__month=date_for.month, | ||
| modified__day__lte=date_for.day) | ||
|
|
||
| # For now, directly doing compat check here and not creating an abstracted |
Contributor
There was a problem hiding this comment.
Suggested change
| # For now, directly doing compat check here and not creating an abstracted | |
| # TODO: Remove this `if` branch after dropping Ginkgo support. | |
| # For now, directly doing compat check here and not creating an abstracted |
Contributor
Author
There was a problem hiding this comment.
Sounds good. Thanks
The issue is that Django 1.8 does not support relative comparison for the 'day' field in QuerySets. Example, this does not work: `SomeModel.objects(my_date_field__day__lte=some_day` So we need to perform an explicit datetime range when running with Django 1.8 Since doing the commit as specified for "non-ginkgo" is more readable, we don't want to throw it away. Instead, when we no longer have to support Django 1.8 (meaning Ginkgo), we can then remove this check in MAU Tests updated to improve date range checking for MAU
johnbaldwin
force-pushed
the
john/fix-ginkgo
branch
from
September 28, 2020 09:42
4c390ac to
eaa0655
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://appsembler.atlassian.net/browse/RED-1348
The issue is that Django 1.8 does not support relative comparison for
the 'day' field in QuerySets. Example, this does not work:
SomeModel.objects(my_date_field__day__lte=some_daySo we need to perform an explicit datetime range when running with
Django 1.8
Since doing the commit as specified for "non-ginkgo" is more readable,
we don't want to throw it away. Instead, when we no longer have to
support Django 1.8 (meaning Ginkgo), we can then remove this check in
MAU
Tests updated to improve date range checking for MAU
Also added missing
django-celeryto the ginkgo requirements file