Skip to content

Conversation

@JayBazuzi
Copy link
Contributor

@JayBazuzi JayBazuzi commented Nov 10, 2024

Fixes #187

Summary by Sourcery

CI:

  • Add Python 3.12 to the testing matrix in the GitHub Actions workflow.

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 10, 2024

Reviewer's Guide by Sourcery

This PR adds Python 3.12 support to the test matrix in the GitHub Actions workflow. The change is straightforward, simply adding Python 3.12 to the list of Python versions tested across different operating systems.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added Python 3.12 to the CI test matrix
  • Added Python 3.12 to the list of Python versions in the test matrix
  • Maintains testing across all existing operating systems (macOS, Ubuntu, Windows)
.github/workflows/test.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#187 Fix the 'No module named distutils' error when running tests under Python 3.12 The PR only adds Python 3.12 to the test matrix in GitHub Actions but does not address the underlying issue with the missing distutils module. The error occurs because distutils was removed in Python 3.12 and the code needs to be updated to use an alternative approach.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@JayBazuzi JayBazuzi changed the title . t Python 3.12 . t Add Python 3.12 to test matrix Nov 10, 2024
@nitsanavni nitsanavni merged commit b2ed91d into approvals:main Nov 11, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No module named 'distutils' running tests under Python 3.12

2 participants