Skip to content

Feature/custom initializer #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 10, 2024
Merged

Feature/custom initializer #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c6e514a
Add comment string as option to be passed to Approov SDK
Sep 17, 2024
a8fa9dc
DEBUG: force fetch a token and log it
Sep 18, 2024
a0dac07
DEBUG: logging
Sep 18, 2024
8c9c2c3
DEBUG: logging exception
Sep 18, 2024
31c795e
DEBUG: new map for reinit
Sep 18, 2024
f124bbc
DEBUG: type exception log
Sep 18, 2024
8361390
Remove debug logs
Sep 18, 2024
c514871
Remove debug logs: typos fix
Sep 18, 2024
bd5ec61
Change variable in existing map
Sep 18, 2024
5c2ad71
Check comment is present during initialization at native level
Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...ain/java/com/criticalblue/approov_service_flutter_httpclient/ApproovHttpClientPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,10 @@ public void onAttachedToEngine(@NonNull FlutterPluginBinding flutterPluginBindin
public void onMethodCall(@NonNull MethodCall call, @NonNull Result result) {
if (call.method.equals("initialize")) {
String initialConfig = call.argument("initialConfig");
if ((initializedConfig == null) || !initializedConfig.equals(initialConfig)) {
// only actually initialize if we haven't before or if there is a change in the
// configuration provided
String commentString = call.argument("comment");
if ((initializedConfig == null) || !initializedConfig.equals(initialConfig) || (commentString != null)) {
// only actually initialize if we haven't before, if there is a change in the
// configuration provided or we have a comment to add to the initialization
try {
Approov.initialize(appContext, initialConfig, call.argument("updateConfig"), call.argument("comment"));
initializedConfig = initialConfig;
Expand Down
6 changes: 3 additions & 3 deletions ios/Classes/ApproovHttpClientPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
if ([@"initialize" isEqualToString:call.method]) {
NSError* error = nil;
NSString *initialConfig = call.arguments[@"initialConfig"];
if ((_initializedConfig == nil) || ![_initializedConfig isEqualToString:initialConfig]) {
// only actually initialize if we haven't before or if there is a change in the
// configuration provided
if ((_initializedConfig == nil) || ![_initializedConfig isEqualToString:initialConfig] || (call.arguments[@"comment"] != [NSNull null])) {
// only actually initialize if we haven't before, if there is a change in the
// configuration provided or thi is a new renitialization
NSString *updateConfig = nil;
if (call.arguments[@"updateConfig"] != [NSNull null])
updateConfig = call.arguments[@"updateConfig"];
Expand Down
Loading