Feature/isolate fix #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om init at the right time
…g callbacks root isolate dependent
Contributor
|
LGTM. One thing to note if it ever arises in a production app and we get complaints: the nature of isolates causes a timeout to happen in the isolate so handling of lack of networking has to be built in the isolate logic by the client application; the example I have been provided with crashed, the shapes out times out with ClientException with SocketException: Connection timed out (OS Error: Connection timed out, errno = 110), address = shapes.approov.io, port = 47630, uri=https://shapes.approov.io/v1/shapes. |
jexh
approved these changes
May 8, 2025
Contributor
jexh
left a comment
jexh
left a comment
There was a problem hiding this comment.
Minor fixes suggested. Otherwise LGTM
...c/main/java/com/criticalblue/approov_service_flutter_httpclient/ApproovHttpClientPlugin.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/criticalblue/approov_service_flutter_httpclient/ApproovHttpClientPlugin.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.