Feature/ignore already initialized #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardmtaylor
approved these changes
Mar 26, 2025
Contributor
richardmtaylor
left a comment
richardmtaylor
left a comment
There was a problem hiding this comment.
Looks good apart from comment fix needed
| } | ||
|
|
||
| /// Provide the initialization config for the Approov SDK. This must be called prior to any other methods on the | ||
| /// ApproovService. This does not actually initialize the SDK at this point, as this is done lazily on the first |
Contributor
There was a problem hiding this comment.
You need to fix these comments
Contributor
Author
|
Changes have been adopted from the feature/isolate-fix branch which subsumes all the changes proposed here. There is no need to merge this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore init if already initialized
Change behavior to initialize when initialize is called
Bump to approov 3.4