Feature/bidirec channel #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fetch; make token prefetch properly asynchronous
jexh
approved these changes
Feb 19, 2025
| // thread since it makes blocking calls. | ||
| // presented on any particular URL to implement the pinning. | ||
| public class ApproovHttpClientPlugin implements FlutterPlugin, MethodCallHandler { | ||
| // CertificatePrefetcher is a Runnable that fetches the certificates for a given URL. This allows the |
Contributor
There was a problem hiding this comment.
Typo: CertificatePrefetcher -> CertificateFetcher
|
|
||
| // setup a Completer for the transaction ID we are going to use | ||
| Completer<dynamic> completer = new Completer<dynamic>(); | ||
| String transactionID = ApproovService.transactionID.toString(); |
Contributor
There was a problem hiding this comment.
I assume this is thread safe in flutter?
Contributor
Author
There was a problem hiding this comment.
Yes, because Dart is single threaded in each isolate. Just uses co-operative scheduling across "awaits".
Contributor
Author
|
So can we go ahead and merge this now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New attempt at cert prefetching with a completely new communication channel implementation. Now uses async callbacks rather than a background thread for the channel as this seemed to lead to very poor performance.