-
Notifications
You must be signed in to change notification settings - Fork 5
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
From this Zulip chat: a scenery/sciview use case requires the following --add-opens flags:
"--add-opens=java.base/java.lang=ALL-UNNAMED",
"--add-opens=java.base/java.lang.invoke=ALL-UNNAMED",
"--add-opens=java.base/java.net=ALL-UNNAMED",
"--add-opens=java.base/java.nio=ALL-UNNAMED",
"--add-opens=java.base/java.time=ALL-UNNAMED",
"--add-opens=java.base/java.util=ALL-UNNAMED",
"--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED",
"--add-opens=java.base/sun.nio.ch=ALL-UNNAMED",
"--add-opens=java.base/sun.util.calendar=ALL-UNNAMED"
This is quite a few more packages than the ones configured in the current fiji.toml. And it highlights an important consideration: extensions to Fiji might need to augment the Jaunch configuration with additional flags.
A general way to address this, which would be compatible with the current ImageJ Updater, would be for Jaunch to look for additional files matching some convention, such as jaunch/fiji-x-*.toml, and load those as well. Then an update site could ship, say, jaunch/fiji-x-sciview.toml, with the additional --add-opens flags needed for that update site's functionality to behave properly with Java 17+.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request