This repository was archived by the owner on Jun 17, 2024. It is now read-only.
Sha3 256 #1
Merged
Sha3 256 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added SHA3-256 hashing function as an OP code
Made required changes to pass the unit tests. -- Changed testAccepts version from 1 to 6 -- Added sha3_256 to the Opgroups
tgrbrooks
reviewed
Jan 31, 2022
tgrbrooks
left a comment
tgrbrooks
left a comment
There was a problem hiding this comment.
Looks great, thank you!
Just a couple of things to double check/change but almost good to go
From code review suggestion renamed opSHA3256 to opSHA3_256 in the eval.go and opcodes.go file
Matt-Ryley
pushed a commit
that referenced
this pull request
Mar 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- The unit tests have been run on my local machine and all pass.