Add compute_tile_highlight to foundation/ColorMap #2801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Mango-3
commented
Mar 14, 2020
Mango-3
commented
- Adds the compute_tile_highlight color function to foundation/ColorMap and makes it dll exportable for usage with the plugins.
dictoon
requested changes
Mar 22, 2020
|
|
||
| Color3f evaluate_palette(float x) const; | ||
|
|
||
| APPLESEED_DLLSYMBOL std::array<float,4> compute_tile_highlight_color( |
Member
There was a problem hiding this comment.
That's not exactly how I saw it:
First, I would suggest to rename the function since it's not really specific to tile highlights. Maybe evaluate_cosine_palette()? There are many more of those by the way: https://www.shadertoy.com/view/ll2GD3, in the future we could consider adding more as needed.
Also, I think this should be a free function instead of static method as it's not related to the ColorMap class.
Finally, it would be more logical to return a Color3f.
| Color3f evaluate_palette(float x) const; | ||
|
|
||
| APPLESEED_DLLSYMBOL std::array<float,4> compute_tile_highlight_color( | ||
| const size_t thread_index, |
Member
There was a problem hiding this comment.
If we rename the method, those should be renamed as well (index, count sound good enough).
| // Choose one color per thread (see https://www.shadertoy.com/view/wlKXDm). | ||
| std::array<float,4> frame_color; | ||
|
|
||
| assert(thread_count != 0); |
|
|
||
| assert(thread_count != 0); | ||
|
|
||
| float t = 2 * 3.14159265359f * (thread_index / static_cast<float>(thread_count)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.