Conversation
Owner
appleboy
commented
Dec 13, 2025
appleboy
commented
- Add conditional checks to prevent Docker registry login steps from running on pull request events
- Add conditional checks to prevent Docker registry login steps from running on pull request events Signed-off-by: appleboy <appleboy.tw@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR adds conditional checks to skip Docker registry authentication steps when the workflow runs on pull request events, improving security by not exposing registry credentials unnecessarily.
- Added
if: github.event_name != 'pull_request'condition to both Docker Hub and GitHub Container Registry login steps - Aligns with the existing conditional push logic that already prevents image pushing on pull requests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.