feat: support parameter handling for dynamic URL paths #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parameter handling for dynamic URL paths ``` - Comment out unused form data encoding in `post` method - Remove redundant error logging in `post` method - Add conditional URL path selection in `trigger` method based on parameters - Add `parameter` flag to CLI options in `main.go` - Include `parameter` in the `run` function configuration - Import `net/url` package in `plugin.go` - Add `Parameter` field to `plugin.go` struct - Parse and add parameters to URL values in `Exec` method - Pass parsed parameters to `trigger` method in `Exec` function Signed-off-by: appleboy <appleboy.tw@gmail.com>
- Simplify the condition to check if `params` is empty in the `trigger` function. Signed-off-by: appleboy <appleboy.tw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postmethodpostmethodtriggermethod based on parametersparameterflag to CLI options inmain.goparameterin therunfunction configurationnet/urlpackage inplugin.goParameterfield toplugin.gostructExecmethodtriggermethod inExecfunctionfix #27
fix #22