Skip to content

Fix: commit preview confirmation behavior #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Fix: commit preview confirmation behavior #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions cmd/commit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,14 +291,18 @@
return err
}

if preview && !noConfirm {
input := confirmation.New("Commit preview summary?", confirmation.Yes)
ready, err := input.RunPrompt()
if err != nil {
return err
}
if !ready {
if preview {
if noConfirm {

Check warning on line 295 in cmd/commit.go

View check run for this annotation

Codecov / codecov/patch

cmd/commit.go#L294-L295 

Added lines #L294 - L295 were not covered by tests
return nil
} else {
input := confirmation.New("Commit preview summary?", confirmation.Yes)
ready, err := input.RunPrompt()
if err != nil {
return err
}
if !ready {
return nil
}

Check warning on line 305 in cmd/commit.go

View check run for this annotation

Codecov / codecov/patch

cmd/commit.go#L297-L305 

Added lines #L297 - L305 were not covered by tests
}
}

Expand Down
Loading