Skip to content

fix(gemini): refactor maxTokens type to int32 across the codebase #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2024
Merged

fix(gemini): refactor maxTokens type to int32 across the codebase #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/openai.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func NewGemini() (*gemini.Client, error) {
return gemini.New(
gemini.WithToken(viper.GetString("openai.api_key")),
gemini.WithModel(viper.GetString("openai.model")),
gemini.WithMaxTokens(viper.GetInt("openai.max_tokens")),
gemini.WithMaxTokens(viper.GetInt32("openai.max_tokens")),
gemini.WithTemperature(float32(viper.GetFloat64("openai.temperature"))),
gemini.WithTopP(float32(viper.GetFloat64("openai.top_p"))),
)
Expand Down
4 changes: 2 additions & 2 deletions gemini/gemini.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
type Client struct {
client *genai.GenerativeModel
model string
maxTokens int
maxTokens int32
temperature float32
topP float32
debug bool
Expand Down Expand Up @@ -106,7 +106,7 @@ func New(opts ...Option) (c *Client, err error) {
}

engine.client = client.GenerativeModel(engine.model)
engine.client.MaxOutputTokens = util.Int32Ptr(int32(engine.maxTokens))
engine.client.MaxOutputTokens = util.Int32Ptr(engine.maxTokens)
engine.client.Temperature = util.Float32Ptr(engine.temperature)
engine.client.TopP = util.Float32Ptr(engine.topP)

Expand Down
4 changes: 2 additions & 2 deletions gemini/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func WithModel(val string) Option {
// WithMaxTokens returns a new Option that sets the max tokens for the client configuration.
// The maximum number of tokens to generate in the chat completion.
// The total length of input tokens and generated tokens is limited by the model's context length.
func WithMaxTokens(val int) Option {
func WithMaxTokens(val int32) Option {
if val <= 0 {
val = defaultMaxTokens
}
Expand Down Expand Up @@ -83,7 +83,7 @@ func WithTopP(val float32) Option {
type config struct {
token string
model string
maxTokens int
maxTokens int32
temperature float32
topP float32
}
Expand Down